BBHs: void* data -> unsigned data

BBHs: void* data -> unsigned data

Now that the old backend's not using BBHs, we can specialize them for
SkRecord's needs.  The only thing we really want to store is op index, which
should always be small enough to fit into an unsigned (unsigned also helps keep
it straight from other ints floating around).

This means we'll need half (32-bit) or a quarter (64-bit) the bytes in SkTileGrid,
because we don't have to store an extra int for ordering.

BUG=skia:2834
Committed: https://skia.googlesource.com/skia/+/6bd41969a0f2283a7a7320bb0025551353c241ec

[mtklein, 2014-10-01 20:47:10]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-10-01 20:48:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/617393004/1

[commit-bot: I haz the power, 2014-10-01 20:48:05]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from a valid reviewer till 2014-10-02 02:48 UTC

[mtklein, 2014-10-01 20:52:18]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-10-01 20:52:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/617393004/20001

[commit-bot: I haz the power, 2014-10-01 20:52:32]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from a valid reviewer till 2014-10-02 02:52 UTC

[mtklein, 2014-10-01 20:58:27]

mtklein@google.com changed reviewers:
+ robertphillips@google.com

[commit-bot: I haz the power, 2014-10-02 02:52:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-02 02:52:36]

No LGTM from a valid reviewer yet. Please ask for an LGTM from a
full Skia committer from
https://skia.googlesource.com/skia/+/master/CQ_COMMITTERS

[robertphillips, 2014-10-02 12:27:35]

lgtm + nits/questions

https://codereview.chromium.org/617393004/diff/20001/src/core/SkTileGrid.cpp
File src/core/SkTileGrid.cpp (right):

https://codereview.chromium.org/617393004/diff/20001/src/core/SkTileGrid.cpp#...
src/core/SkTileGrid.cpp:25: 
data -> opIndex everywhere ?

https://codereview.chromium.org/617393004/diff/20001/src/core/SkTileGrid.cpp#...
src/core/SkTileGrid.cpp:105: results->setCount(tile.count());
*results = tile; ?

https://codereview.chromium.org/617393004/diff/20001/src/core/SkTileGrid.cpp#...
src/core/SkTileGrid.cpp:128: // It may be at the front of several, even all,
tiles.
It seems like earliest shouldn't be a pointer anymore.

https://codereview.chromium.org/617393004/diff/20001/tests/BBoxHierarchyTest.cpp
File tests/BBoxHierarchyTest.cpp (right):

https://codereview.chromium.org/617393004/diff/20001/tests/BBoxHierarchyTest....
tests/BBoxHierarchyTest.cpp:45: 
one line ?

https://codereview.chromium.org/617393004/diff/20001/tests/BBoxHierarchyTest....
tests/BBoxHierarchyTest.cpp:66: 
Are these sorts really necessary ?

https://codereview.chromium.org/617393004/diff/20001/tests/PictureTest.cpp
File tests/PictureTest.cpp (right):

https://codereview.chromium.org/617393004/diff/20001/tests/PictureTest.cpp#ne...
tests/PictureTest.cpp:1867: 
SK_OVERRIDE ?

https://codereview.chromium.org/617393004/diff/20001/tests/PictureTest.cpp#ne...
tests/PictureTest.cpp:1872: // All other methods unimplemented.
same here ?

https://codereview.chromium.org/617393004/diff/20001/tests/RTreeTest.cpp
File tests/RTreeTest.cpp (right):

https://codereview.chromium.org/617393004/diff/20001/tests/RTreeTest.cpp#newc...
tests/RTreeTest.cpp:65: 
same here

https://codereview.chromium.org/617393004/diff/20001/tests/RecordDrawTest.cpp
File tests/RecordDrawTest.cpp (right):

https://codereview.chromium.org/617393004/diff/20001/tests/RecordDrawTest.cpp...
tests/RecordDrawTest.cpp:116: };
fEntries ?

https://codereview.chromium.org/617393004/diff/20001/tests/TileGridTest.cpp
File tests/TileGridTest.cpp (right):

https://codereview.chromium.org/617393004/diff/20001/tests/TileGridTest.cpp#n...
tests/TileGridTest.cpp:33: 
verify_tile_hit ?

[mtklein, 2014-10-02 14:32:10]

https://codereview.chromium.org/617393004/diff/20001/src/core/SkTileGrid.cpp
File src/core/SkTileGrid.cpp (right):

https://codereview.chromium.org/617393004/diff/20001/src/core/SkTileGrid.cpp#...
src/core/SkTileGrid.cpp:25: 
On 2014/10/02 12:27:35, robertphillips wrote:
> data -> opIndex everywhere ?

Done.

https://codereview.chromium.org/617393004/diff/20001/src/core/SkTileGrid.cpp#...
src/core/SkTileGrid.cpp:105: results->setCount(tile.count());
On 2014/10/02 12:27:35, robertphillips wrote:
> *results = tile; ?

Done.

https://codereview.chromium.org/617393004/diff/20001/src/core/SkTileGrid.cpp#...
src/core/SkTileGrid.cpp:128: // It may be at the front of several, even all,
tiles.
On 2014/10/02 12:27:35, robertphillips wrote:
> It seems like earliest shouldn't be a pointer anymore.

Agreed, though I'm going to follow up on this one.

https://codereview.chromium.org/617393004/diff/20001/tests/BBoxHierarchyTest.cpp
File tests/BBoxHierarchyTest.cpp (right):

https://codereview.chromium.org/617393004/diff/20001/tests/BBoxHierarchyTest....
tests/BBoxHierarchyTest.cpp:45: 
On 2014/10/02 12:27:35, robertphillips wrote:
> one line ?

Done.

https://codereview.chromium.org/617393004/diff/20001/tests/BBoxHierarchyTest....
tests/BBoxHierarchyTest.cpp:66: 
On 2014/10/02 12:27:35, robertphillips wrote:
> Are these sorts really necessary ?

Looking more closely at this file, it turns out this entire file is a near exact
duplicate of tests/RTreeTest.cpp.  WTF.  I'm deleting this one.

https://codereview.chromium.org/617393004/diff/20001/tests/PictureTest.cpp
File tests/PictureTest.cpp (right):

https://codereview.chromium.org/617393004/diff/20001/tests/PictureTest.cpp#ne...
tests/PictureTest.cpp:1867: 
On 2014/10/02 12:27:35, robertphillips wrote:
> SK_OVERRIDE ?

Done.

https://codereview.chromium.org/617393004/diff/20001/tests/PictureTest.cpp#ne...
tests/PictureTest.cpp:1872: // All other methods unimplemented.
On 2014/10/02 12:27:35, robertphillips wrote:
> same here ?

Done.

https://codereview.chromium.org/617393004/diff/20001/tests/RTreeTest.cpp
File tests/RTreeTest.cpp (right):

https://codereview.chromium.org/617393004/diff/20001/tests/RTreeTest.cpp#newc...
tests/RTreeTest.cpp:65: 
On 2014/10/02 12:27:35, robertphillips wrote:
> same here

Turns out this sort is needed!  I reopened skia:2834.

https://codereview.chromium.org/617393004/diff/20001/tests/RecordDrawTest.cpp
File tests/RecordDrawTest.cpp (right):

https://codereview.chromium.org/617393004/diff/20001/tests/RecordDrawTest.cpp...
tests/RecordDrawTest.cpp:116: };
On 2014/10/02 12:27:35, robertphillips wrote:
> fEntries ?

Done.

https://codereview.chromium.org/617393004/diff/20001/tests/TileGridTest.cpp
File tests/TileGridTest.cpp (right):

https://codereview.chromium.org/617393004/diff/20001/tests/TileGridTest.cpp#n...
tests/TileGridTest.cpp:33: 
On 2014/10/02 12:27:35, robertphillips wrote:
> verify_tile_hit ?

Done.

[mtklein, 2014-10-02 14:32:18]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-10-02 14:33:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/617393004/60001

[commit-bot: I haz the power, 2014-10-02 14:42:03]

Committed patchset #4 (id:60001) as 6bd41969a0f2283a7a7320bb0025551353c241ec