Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 617183005: Split the NullInitialized signal out of TrustedInitialized. (Closed)

Created:
6 years, 2 months ago by gab
Modified:
6 years, 2 months ago
Reviewers:
Bernhard Bauer, jwd
CC:
chromium-reviews, asvitkine+watch_chromium.org, erikwright (departed)
Base URL:
https://chromium.googlesource.com/chromium/src.git@c1_move_to_tracked
Project:
chromium
Visibility:
Public.

Description

Split the NullInitialized signal out of TrustedInitialized. BUG=419505 Committed: https://crrev.com/342aa6189ac649faefe6cb93be0ecb1f1c41c3d1 Cr-Commit-Position: refs/heads/master@{#297916}

Patch Set 1 #

Patch Set 2 : fix PrefHashBrowserTest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -24 lines) Patch
M chrome/browser/prefs/tracked/pref_hash_browsertest.cc View 1 8 chunks +23 lines, -5 lines 0 comments Download
M chrome/browser/prefs/tracked/pref_hash_filter_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/prefs/tracked/pref_hash_store_impl.cc View 2 chunks +9 lines, -6 lines 0 comments Download
M chrome/browser/prefs/tracked/pref_hash_store_impl_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/prefs/tracked/pref_hash_store_transaction.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/prefs/tracked/tracked_preference_helper.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
gab
Bernhard, PTAL, this is based on top of https://codereview.chromium.org/620933002/. Cheers, Gab
6 years, 2 months ago (2014-10-01 20:51:40 UTC) #2
gab
On 2014/10/01 20:51:40, gab wrote: > Bernhard, PTAL, this is based on top of > ...
6 years, 2 months ago (2014-10-01 20:52:14 UTC) #3
gab
On 2014/10/01 20:52:14, gab wrote: > On 2014/10/01 20:51:40, gab wrote: > > Bernhard, PTAL, ...
6 years, 2 months ago (2014-10-01 20:53:26 UTC) #6
Bernhard Bauer
lgtm.
6 years, 2 months ago (2014-10-02 06:38:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/617183005/1
6 years, 2 months ago (2014-10-02 12:17:55 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/14995)
6 years, 2 months ago (2014-10-02 12:27:12 UTC) #11
jwd
lgtm
6 years, 2 months ago (2014-10-02 21:05:45 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/617183005/20001
6 years, 2 months ago (2014-10-02 21:08:12 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 712b2b8978caf2db6a780b0d8fb329f902689c18
6 years, 2 months ago (2014-10-02 21:59:11 UTC) #17
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 22:00:29 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/342aa6189ac649faefe6cb93be0ecb1f1c41c3d1
Cr-Commit-Position: refs/heads/master@{#297916}

Powered by Google App Engine
This is Rietveld 408576698