Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6504)

Unified Diff: chrome/browser/prefs/tracked/tracked_preference_helper.cc

Issue 617183005: Split the NullInitialized signal out of TrustedInitialized. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@c1_move_to_tracked
Patch Set: fix PrefHashBrowserTest Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/prefs/tracked/pref_hash_store_transaction.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prefs/tracked/tracked_preference_helper.cc
diff --git a/chrome/browser/prefs/tracked/tracked_preference_helper.cc b/chrome/browser/prefs/tracked/tracked_preference_helper.cc
index 90bc11f31c6765c65a7edb969ed84027fb2cf7c7..1da583f2094554a4c5b7b448d78a783c0e88b393 100644
--- a/chrome/browser/prefs/tracked/tracked_preference_helper.cc
+++ b/chrome/browser/prefs/tracked/tracked_preference_helper.cc
@@ -26,6 +26,7 @@ TrackedPreferenceHelper::ResetAction TrackedPreferenceHelper::GetAction(
case PrefHashStoreTransaction::CLEARED:
// Unfortunate case, but there is nothing we can do.
return DONT_RESET;
+ case PrefHashStoreTransaction::TRUSTED_NULL_VALUE: // Falls through.
case PrefHashStoreTransaction::TRUSTED_UNKNOWN_VALUE:
// It is okay to seed the hash in this case.
return DONT_RESET;
@@ -69,6 +70,10 @@ void TrackedPreferenceHelper::ReportValidationResult(
UMA_HISTOGRAM_ENUMERATION("Settings.TrackedPreferenceTrustedInitialized",
reporting_id_, reporting_ids_count_);
return;
+ case PrefHashStoreTransaction::TRUSTED_NULL_VALUE:
+ UMA_HISTOGRAM_ENUMERATION("Settings.TrackedPreferenceNullInitialized",
+ reporting_id_, reporting_ids_count_);
+ return;
}
NOTREACHED() << "Unexpected PrefHashStoreTransaction::ValueState: "
<< value_state;
« no previous file with comments | « chrome/browser/prefs/tracked/pref_hash_store_transaction.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698