Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1715)

Unified Diff: chrome/browser/prefs/tracked/pref_hash_filter_unittest.cc

Issue 617183005: Split the NullInitialized signal out of TrustedInitialized. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@c1_move_to_tracked
Patch Set: fix PrefHashBrowserTest Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prefs/tracked/pref_hash_filter_unittest.cc
diff --git a/chrome/browser/prefs/tracked/pref_hash_filter_unittest.cc b/chrome/browser/prefs/tracked/pref_hash_filter_unittest.cc
index 34b400a48baaaf7bc84fe1234791cde84ff680ab..ed6adcb63a63adc1dcf8c71831b466c48ca0c0a0 100644
--- a/chrome/browser/prefs/tracked/pref_hash_filter_unittest.cc
+++ b/chrome/browser/prefs/tracked/pref_hash_filter_unittest.cc
@@ -626,14 +626,14 @@ TEST_P(PrefHashFilterTest, MultiplePrefsFilterSerializeData) {
ASSERT_EQ(PrefHashFilter::TRACKING_STRATEGY_SPLIT, stored_value_split.second);
}
-TEST_P(PrefHashFilterTest, EmptyAndUnknown) {
+TEST_P(PrefHashFilterTest, UnknownNullValue) {
ASSERT_FALSE(pref_store_contents_->Get(kAtomicPref, NULL));
ASSERT_FALSE(pref_store_contents_->Get(kSplitPref, NULL));
// NULL values are always trusted by the PrefHashStore.
mock_pref_hash_store_->SetCheckResult(
- kAtomicPref, PrefHashStoreTransaction::TRUSTED_UNKNOWN_VALUE);
+ kAtomicPref, PrefHashStoreTransaction::TRUSTED_NULL_VALUE);
mock_pref_hash_store_->SetCheckResult(
- kSplitPref, PrefHashStoreTransaction::TRUSTED_UNKNOWN_VALUE);
+ kSplitPref, PrefHashStoreTransaction::TRUSTED_NULL_VALUE);
DoFilterOnLoad(false);
ASSERT_EQ(arraysize(kTestTrackedPrefs),
mock_pref_hash_store_->checked_paths_count());
@@ -657,7 +657,7 @@ TEST_P(PrefHashFilterTest, EmptyAndUnknown) {
mock_validation_delegate_.recorded_validations_count());
ASSERT_EQ(2u,
mock_validation_delegate_.CountValidationsOfState(
- PrefHashStoreTransaction::TRUSTED_UNKNOWN_VALUE));
+ PrefHashStoreTransaction::TRUSTED_NULL_VALUE));
ASSERT_EQ(arraysize(kTestTrackedPrefs) - 2u,
mock_validation_delegate_.CountValidationsOfState(
PrefHashStoreTransaction::UNCHANGED));
« no previous file with comments | « chrome/browser/prefs/tracked/pref_hash_browsertest.cc ('k') | chrome/browser/prefs/tracked/pref_hash_store_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698