Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 617123005: Remove BrowserPlugin tests (only one test remaining with existing coverage) (Closed)

Created:
6 years, 2 months ago by Fady Samuel
Modified:
6 years, 2 months ago
Reviewers:
Charlie Reis, lazyboy
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@make_lifetime_explicit
Project:
chromium
Visibility:
Public.

Description

Remove BrowserPlugin tests (only one test remaining with existing coverage) This test coverage already exists in chrome and extensions now. BUG=330264 Committed: https://crrev.com/f32d1c4cf0ed2d34784c60342bd4ca13a53fd2cd Cr-Commit-Position: refs/heads/master@{#297874}

Patch Set 1 #

Patch Set 2 : More cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -557 lines) Patch
M content/content_renderer.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -6 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin.h View 1 chunk +1 line, -2 lines 0 comments Download
D content/renderer/browser_plugin/browser_plugin_browsertest.h View 1 chunk +0 lines, -50 lines 0 comments Download
D content/renderer/browser_plugin/browser_plugin_browsertest.cc View 1 chunk +0 lines, -173 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin_manager.h View 1 4 chunks +6 lines, -23 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin_manager.cc View 1 2 chunks +38 lines, -11 lines 0 comments Download
D content/renderer/browser_plugin/browser_plugin_manager_factory.h View 1 chunk +0 lines, -21 lines 0 comments Download
D content/renderer/browser_plugin/browser_plugin_manager_impl.h View 1 chunk +0 lines, -44 lines 0 comments Download
D content/renderer/browser_plugin/browser_plugin_manager_impl.cc View 1 chunk +0 lines, -60 lines 0 comments Download
D content/renderer/browser_plugin/mock_browser_plugin.h View 1 chunk +0 lines, -27 lines 0 comments Download
D content/renderer/browser_plugin/mock_browser_plugin.cc View 1 chunk +0 lines, -20 lines 0 comments Download
D content/renderer/browser_plugin/mock_browser_plugin_manager.h View 1 chunk +0 lines, -54 lines 0 comments Download
D content/renderer/browser_plugin/mock_browser_plugin_manager.cc View 1 chunk +0 lines, -61 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/renderer_main.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
Fady Samuel
6 years, 2 months ago (2014-10-01 23:10:12 UTC) #2
lazyboy
lgtm
6 years, 2 months ago (2014-10-02 06:55:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/617123005/20001
6 years, 2 months ago (2014-10-02 06:55:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/617123005/20001
6 years, 2 months ago (2014-10-02 10:47:11 UTC) #8
Fady Samuel
6 years, 2 months ago (2014-10-02 10:47:23 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/14980)
6 years, 2 months ago (2014-10-02 10:55:53 UTC) #12
Charlie Reis
LGTM. Thanks for cleaning it up after the move!
6 years, 2 months ago (2014-10-02 17:41:29 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/617123005/20001
6 years, 2 months ago (2014-10-02 17:48:42 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 75469f6e264a8f1746281e8fbe881525464ed968
6 years, 2 months ago (2014-10-02 19:07:03 UTC) #16
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 19:07:36 UTC) #17
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/f32d1c4cf0ed2d34784c60342bd4ca13a53fd2cd
Cr-Commit-Position: refs/heads/master@{#297874}

Powered by Google App Engine
This is Rietveld 408576698