Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Side by Side Diff: content/renderer/browser_plugin/browser_plugin.h

Issue 617123005: Remove BrowserPlugin tests (only one test remaining with existing coverage) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@make_lifetime_explicit
Patch Set: More cleanup Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_BROWSER_PLUGIN_BROWSER_PLUGIN_H_ 5 #ifndef CONTENT_RENDERER_BROWSER_PLUGIN_BROWSER_PLUGIN_H_
6 #define CONTENT_RENDERER_BROWSER_PLUGIN_BROWSER_PLUGIN_H_ 6 #define CONTENT_RENDERER_BROWSER_PLUGIN_BROWSER_PLUGIN_H_
7 7
8 #include "third_party/WebKit/public/web/WebPlugin.h" 8 #include "third_party/WebKit/public/web/WebPlugin.h"
9 9
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 130
131 // MouseLockDispatcher::LockTarget implementation. 131 // MouseLockDispatcher::LockTarget implementation.
132 virtual void OnLockMouseACK(bool succeeded) OVERRIDE; 132 virtual void OnLockMouseACK(bool succeeded) OVERRIDE;
133 virtual void OnMouseLockLost() OVERRIDE; 133 virtual void OnMouseLockLost() OVERRIDE;
134 virtual bool HandleMouseLockedInputEvent( 134 virtual bool HandleMouseLockedInputEvent(
135 const blink::WebMouseEvent& event) OVERRIDE; 135 const blink::WebMouseEvent& event) OVERRIDE;
136 136
137 private: 137 private:
138 friend class base::DeleteHelper<BrowserPlugin>; 138 friend class base::DeleteHelper<BrowserPlugin>;
139 // Only the manager is allowed to create a BrowserPlugin. 139 // Only the manager is allowed to create a BrowserPlugin.
140 friend class BrowserPluginManagerImpl; 140 friend class BrowserPluginManager;
141 friend class MockBrowserPluginManager;
142 141
143 // For unit/integration tests. 142 // For unit/integration tests.
144 friend class MockBrowserPlugin; 143 friend class MockBrowserPlugin;
145 144
146 // A BrowserPlugin object is a controller that represents an instance of a 145 // A BrowserPlugin object is a controller that represents an instance of a
147 // browser plugin within the embedder renderer process. Once a BrowserPlugin 146 // browser plugin within the embedder renderer process. Once a BrowserPlugin
148 // does an initial navigation or is attached to a newly created guest, it 147 // does an initial navigation or is attached to a newly created guest, it
149 // acquires a browser_plugin_instance_id as well. The guest instance ID 148 // acquires a browser_plugin_instance_id as well. The guest instance ID
150 // uniquely identifies a guest WebContents that's hosted by this 149 // uniquely identifies a guest WebContents that's hosted by this
151 // BrowserPlugin. 150 // BrowserPlugin.
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
229 // Weak factory used in v8 |MakeWeak| callback, since the v8 callback might 228 // Weak factory used in v8 |MakeWeak| callback, since the v8 callback might
230 // get called after BrowserPlugin has been destroyed. 229 // get called after BrowserPlugin has been destroyed.
231 base::WeakPtrFactory<BrowserPlugin> weak_ptr_factory_; 230 base::WeakPtrFactory<BrowserPlugin> weak_ptr_factory_;
232 231
233 DISALLOW_COPY_AND_ASSIGN(BrowserPlugin); 232 DISALLOW_COPY_AND_ASSIGN(BrowserPlugin);
234 }; 233 };
235 234
236 } // namespace content 235 } // namespace content
237 236
238 #endif // CONTENT_RENDERER_BROWSER_PLUGIN_BROWSER_PLUGIN_H_ 237 #endif // CONTENT_RENDERER_BROWSER_PLUGIN_BROWSER_PLUGIN_H_
OLDNEW
« no previous file with comments | « content/content_tests.gypi ('k') | content/renderer/browser_plugin/browser_plugin_browsertest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698