content/renderer/browser_plugin/browser_plugin.h - Issue 617123005: Remove BrowserPlugin tests (only one test remaining with existing coverage)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/browser_plugin/browser_plugin.h

Issue 617123005: Remove BrowserPlugin tests (only one test remaining with existing coverage) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@make_lifetime_explicit

Patch Set: More cleanup Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/browser_plugin/browser_plugin.h

diff --git a/content/renderer/browser_plugin/browser_plugin.h b/content/renderer/browser_plugin/browser_plugin.h

index 11f766107433080cf478caba76513237b4d054f1..1ee6992b5fa6e1a0a6b54b006aa0fee20e9804cb 100644

--- a/content/renderer/browser_plugin/browser_plugin.h

+++ b/content/renderer/browser_plugin/browser_plugin.h

@@ -137,8 +137,7 @@ class CONTENT_EXPORT BrowserPlugin :

private:

friend class base::DeleteHelper<BrowserPlugin>;

// Only the manager is allowed to create a BrowserPlugin.

- friend class BrowserPluginManagerImpl;

- friend class MockBrowserPluginManager;

+ friend class BrowserPluginManager;

// For unit/integration tests.

friend class MockBrowserPlugin;

« no previous file with comments | « content/content_tests.gypi ('k') | content/renderer/browser_plugin/browser_plugin_browsertest.h » ('j') | no next file with comments »