Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 616923002: Add wpr_modes.WPR_APPEND. (Closed)

Created:
6 years, 2 months ago by slamm
Modified:
6 years, 2 months ago
Reviewers:
wuhu, nednguyen, chrishenry
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add wpr_modes.WPR_APPEND. BUG=404771 Committed: https://crrev.com/cd62dd512f2e773db3f50a1eab7f57754fd2ac1d Cr-Commit-Position: refs/heads/master@{#297491}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -14 lines) Patch
M tools/telemetry/telemetry/core/browser.py View 1 chunk +6 lines, -6 lines 0 comments Download
M tools/telemetry/telemetry/core/wpr_modes.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/wpr_server.py View 2 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
slamm
Pulling a tiny change out of my larger change to fold webpagereplay into wpr_server.
6 years, 2 months ago (2014-09-30 15:50:15 UTC) #2
wuhu
lgtm
6 years, 2 months ago (2014-09-30 16:42:34 UTC) #3
nednguyen
On 2014/09/30 16:42:34, wuhu wrote: > lgtm lgtm Since you add a new wpr mode, ...
6 years, 2 months ago (2014-09-30 16:45:52 UTC) #4
chromium-reviews
The page_runner is in my sights for a later CL. I feel confident that this ...
6 years, 2 months ago (2014-09-30 17:44:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/616923002/1
6 years, 2 months ago (2014-09-30 18:40:57 UTC) #7
chrishenry
lgtm
6 years, 2 months ago (2014-09-30 19:06:17 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as 035bbd3c9f0bd24989e7250a5d58f93eec79af80
6 years, 2 months ago (2014-09-30 20:29:47 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 20:30:31 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd62dd512f2e773db3f50a1eab7f57754fd2ac1d
Cr-Commit-Position: refs/heads/master@{#297491}

Powered by Google App Engine
This is Rietveld 408576698