Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: tools/telemetry/telemetry/core/browser.py

Issue 616923002: Add wpr_modes.WPR_APPEND. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/wpr_modes.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/browser.py
diff --git a/tools/telemetry/telemetry/core/browser.py b/tools/telemetry/telemetry/core/browser.py
index dca7a06176cbddf9d2d4909e42a9d185f97ec2e3..600e26c96156389443e1ec3964eb1092f6fa6c78 100644
--- a/tools/telemetry/telemetry/core/browser.py
+++ b/tools/telemetry/telemetry/core/browser.py
@@ -319,18 +319,18 @@ class Browser(object):
if not archive_path:
return None
- if self._browser_backend.wpr_mode == wpr_modes.WPR_OFF:
+ wpr_mode = self._browser_backend.wpr_mode
+ if wpr_mode == wpr_modes.WPR_OFF:
return
-
- use_record_mode = self._browser_backend.wpr_mode == wpr_modes.WPR_RECORD
- if not use_record_mode:
+ if wpr_mode == wpr_modes.WPR_RECORD and append_to_existing_wpr:
+ wpr_mode = wpr_modes.WPR_APPEND
+ if wpr_mode == wpr_modes.WPR_REPLAY:
assert os.path.isfile(archive_path)
self._wpr_server = wpr_server.ReplayServer(
self._browser_backend,
archive_path,
- use_record_mode,
- append_to_existing_wpr,
+ wpr_mode,
make_javascript_deterministic)
def GetStandardOutput(self):
« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/wpr_modes.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698