Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: tools/telemetry/telemetry/core/wpr_server.py

Issue 616923002: Add wpr_modes.WPR_APPEND. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/core/wpr_modes.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/wpr_server.py
diff --git a/tools/telemetry/telemetry/core/wpr_server.py b/tools/telemetry/telemetry/core/wpr_server.py
index d78564c70b870c5f539521a84fd2ad6bf71d3dde..58eb1c8cbf84beaa8e2965acf25a2891dd3b3c2a 100644
--- a/tools/telemetry/telemetry/core/wpr_server.py
+++ b/tools/telemetry/telemetry/core/wpr_server.py
@@ -4,6 +4,7 @@
from telemetry.core import forwarders
from telemetry.core import webpagereplay
+from telemetry.core import wpr_modes
# TODO(tonyg): Move webpagereplay.py's guts into this class and
@@ -11,20 +12,17 @@ from telemetry.core import webpagereplay
class ReplayServer(object):
- def __init__(self, browser_backend, path, is_record_mode, is_append_mode,
+ def __init__(self, browser_backend, path, wpr_mode,
make_javascript_deterministic):
self._browser_backend = browser_backend
self._forwarder = None
self._web_page_replay = None
- self._is_record_mode = is_record_mode
- self._is_append_mode = is_append_mode
wpr_args = browser_backend.browser_options.extra_wpr_args
- if self._is_record_mode:
- if self._is_append_mode:
- wpr_args.append('--append')
- else:
- wpr_args.append('--record')
+ if wpr_mode == wpr_modes.WPR_APPEND:
+ wpr_args.append('--append')
+ elif wpr_mode == wpr_modes.WPR_RECORD:
+ wpr_args.append('--record')
if not make_javascript_deterministic:
wpr_args.append('--inject_scripts=')
browser_backend.AddReplayServerOptions(wpr_args)
« no previous file with comments | « tools/telemetry/telemetry/core/wpr_modes.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698