Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 616693002: Kill page.disabled field. (Closed)

Created:
6 years, 2 months ago by nednguyen
Modified:
6 years, 2 months ago
Reviewers:
dtu, chrishenry
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Kill page.disabled field. If someone wants to disable a page, the right way to do it is comment out the "self.AddPage(...)" in page_set.__init__(). BUG= Committed: https://crrev.com/3a2e10b34a2990c931e0a2c2fb3c6ac935937dc2 Cr-Commit-Position: refs/heads/master@{#297348}

Patch Set 1 #

Patch Set 2 : Remove disabled check in benchmark_unittest #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -31 lines) Patch
M tools/perf/benchmarks/benchmark_unittest.py View 1 1 chunk +3 lines, -4 lines 0 comments Download
M tools/perf/page_sets/key_mobile_sites.py View 1 2 5 chunks +12 lines, -13 lines 0 comments Download
M tools/perf/page_sets/key_silk_cases.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/page_sets/tough_canvas_cases.py View 2 chunks +2 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/page/__init__.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/page/page_runner.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/unittest/page_set_smoke_test.py View 3 chunks +11 lines, -7 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
nednguyen
6 years, 2 months ago (2014-09-29 22:59:56 UTC) #2
nednguyen
6 years, 2 months ago (2014-09-29 23:02:29 UTC) #4
dtu
lgtm
6 years, 2 months ago (2014-09-29 23:11:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/616693002/1
6 years, 2 months ago (2014-09-29 23:23:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/616693002/20001
6 years, 2 months ago (2014-09-29 23:28:17 UTC) #10
commit-bot: I haz the power
Failed to apply patch for tools/perf/page_sets/key_mobile_sites.py: While running git apply --index -3 -p1; error: patch ...
6 years, 2 months ago (2014-09-30 00:33:40 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/616693002/40001
6 years, 2 months ago (2014-09-30 01:20:23 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 1f7420f034d25519df9d00d69f61cd985f76e8c5
6 years, 2 months ago (2014-09-30 02:56:12 UTC) #15
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 02:56:57 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3a2e10b34a2990c931e0a2c2fb3c6ac935937dc2
Cr-Commit-Position: refs/heads/master@{#297348}

Powered by Google App Engine
This is Rietveld 408576698