tools/perf/benchmarks/benchmark_unittest.py - Issue 616693002: Kill page.disabled field.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/benchmarks/benchmark_unittest.py

Issue 616693002: Kill page.disabled field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/benchmarks/benchmark_unittest.py

diff --git a/tools/perf/benchmarks/benchmark_unittest.py b/tools/perf/benchmarks/benchmark_unittest.py

index d5aff221ef9a04e88cd5230a2bc196e23d9628de..c37d28b3267973b02b190b2876f98bbfb05f45f0 100644

--- a/tools/perf/benchmarks/benchmark_unittest.py

+++ b/tools/perf/benchmarks/benchmark_unittest.py

@@ -36,10 +36,9 @@ def SmokeTestGenerator(benchmark):

# pylint: disable=E1002

ps = super(SinglePageBenchmark, self).CreatePageSet(options)

for p in ps.pages:

- if not p.disabled:

- p.skip_waits = True

- ps.pages = [p]

- break

+ p.skip_waits = True

+ ps.pages = [p]

+ break

return ps

# Set the benchmark's default arguments.

« no previous file with comments | « no previous file | tools/perf/page_sets/key_mobile_sites.py » ('j') | no next file with comments »