tools/telemetry/telemetry/page/page_runner.py - Issue 616693002: Kill page.disabled field.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/page_runner.py

Issue 616693002: Kill page.disabled field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/page/page_runner.py

diff --git a/tools/telemetry/telemetry/page/page_runner.py b/tools/telemetry/telemetry/page/page_runner.py

index fa5c347cfffc56a19c375ae1cdf5c0f1c1b3bd95..648284f46cc0faf3a9d528f628ccf1a30434f280 100644

--- a/tools/telemetry/telemetry/page/page_runner.py

+++ b/tools/telemetry/telemetry/page/page_runner.py

@@ -433,7 +433,7 @@ def _ShuffleAndFilterPageSet(page_set, finder_options):

if finder_options.pageset_shuffle_order_file:

return page_set.ReorderPageSet(finder_options.pageset_shuffle_order_file)

pages = [page for page in page_set.pages[:]

- if not page.disabled and page_filter.PageFilter.IsSelected(page)]

+ if page_filter.PageFilter.IsSelected(page)]

if finder_options.pageset_shuffle:

random.shuffle(pages)

return pages