Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: util/mac/mach_o_image_reader.cc

Issue 615923004: Convert COMPILE_ASSERT to static_assert (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« util/file/string_file_writer_test.cc ('K') | « util/file/string_file_writer_test.cc ('k') | util/mac/mach_o_image_segment_reader.cc » ('j') | util/mach/exc_server_variants_test.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/mac/mach_o_image_reader.cc
diff --git a/util/mac/mach_o_image_reader.cc b/util/mac/mach_o_image_reader.cc
index 09e35e59f2f612f77bd3e9eaf82cd043c08b5651..3ba2cd63222678ad0a7e25d1095685f537d47bc4 100644
--- a/util/mac/mach_o_image_reader.cc
+++ b/util/mac/mach_o_image_reader.cc
@@ -328,7 +328,7 @@ const process_types::section* MachOImageReader::GetSectionAtIndex(
mach_vm_address_t* address) const {
INITIALIZATION_STATE_DCHECK_VALID(initialized_);
- COMPILE_ASSERT(NO_SECT == 0, no_sect_must_be_zero);
+ static_assert(NO_SECT == 0, "no sect must be zero");
Mark Mentovai 2014/10/01 03:55:12 "NO_SECT must be 0"
scottmg 2014/10/01 16:37:19 Done.
if (index == NO_SECT) {
LOG(WARNING) << "section index " << index << " out of range";
return NULL;
« util/file/string_file_writer_test.cc ('K') | « util/file/string_file_writer_test.cc ('k') | util/mac/mach_o_image_segment_reader.cc » ('j') | util/mach/exc_server_variants_test.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698