Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: util/file/string_file_writer_test.cc

Issue 615923004: Convert COMPILE_ASSERT to static_assert (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: util/file/string_file_writer_test.cc
diff --git a/util/file/string_file_writer_test.cc b/util/file/string_file_writer_test.cc
index f0ec72f75e958da164887f85767abcaef9f82d7d..628b7d0893a7094bde8e0b07666d52e72b00fd67 100644
--- a/util/file/string_file_writer_test.cc
+++ b/util/file/string_file_writer_test.cc
@@ -354,8 +354,8 @@ TEST(StringFileWriter, SeekInvalid) {
EXPECT_EQ(1, writer.Seek(0, SEEK_CUR));
EXPECT_TRUE(writer.string().empty());
- COMPILE_ASSERT(SEEK_SET != 3 && SEEK_CUR != 3 && SEEK_END != 3,
- three_must_be_invalid_for_whence);
+ static_assert(SEEK_SET != 3 && SEEK_CUR != 3 && SEEK_END != 3,
+ "three must be invalid for whence");
Mark Mentovai 2014/10/01 03:55:12 This can be a numeral 3 now, since there’s no rest
scottmg 2014/10/01 16:37:19 Done.
EXPECT_LT(writer.Seek(0, 3), 0);
writer.Reset();

Powered by Google App Engine
This is Rietveld 408576698