util/mach/exc_server_variants_test.cc - Issue 615923004: Convert COMPILE_ASSERT to static_assert

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: util/mach/exc_server_variants_test.cc

Issue 615923004: Convert COMPILE_ASSERT to static_assert (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: util/mach/exc_server_variants_test.cc

diff --git a/util/mach/exc_server_variants_test.cc b/util/mach/exc_server_variants_test.cc

index 9f4963a39433663e5677e748175f6403e73cd91d..ad963d6c2dbf9a302ec433399bfef418d75a92fe 100644

--- a/util/mach/exc_server_variants_test.cc

+++ b/util/mach/exc_server_variants_test.cc

@@ -1114,7 +1114,7 @@ TEST(ExcServerVariants, ExcCrashRecoverOriginalException) {

// Now make sure that ExcCrashRecoverOriginalException() properly ignores

// optional arguments.

- COMPILE_ASSERT(arraysize(kTestData) >= 1, must_have_something_to_test);

+ static assert(arraysize(kTestData) >= 1, "must have something to test");

Mark Mentovai 2014/10/01 03:55:12 Missing underscore: static_assert. Same as in uuid

scottmg 2014/10/01 16:37:19 Done.

const TestData& test_data = kTestData[0];

EXPECT_EQ(test_data.exception,

ExcCrashRecoverOriginalException(test_data.code_0, NULL, NULL));