Credential Manager: Extract browser-side IPC to a stand-alone dispatcher.

Credential Manager: Extract browser-side IPC to a stand-alone dispatcher.

No functional change in this bug, but it paves the way to doing real work
with the PasswordStore by separating the IPC-handling bits from the
PasswordManagerClient implementation so that we can easily subclass
PasswordStoreConsumer in a way that keeps all the credential functionality
well-contained in a single object for clarity.

BUG=400674
Committed: https://crrev.com/07f0d3dda6cb3d13f6116c778b02efb6a29ccae7
Cr-Commit-Position: refs/heads/master@{#297161}

[Mike West, 2014-09-29 10:31:24]

mkwst@chromium.org changed reviewers:
+ vabr@chromium.org

[Mike West, 2014-09-29 10:31:24]

Vaclav, would you mind taking a first pass at this? It's a fairly mechanical
change, just extracting functionality from the client and putting it into a new
object that the client creates and owns.

Thanks!

[vabr (Chromium), 2014-09-29 11:05:27]

LGTM with 2 comments and one squeal. :)
Vaclav

https://codereview.chromium.org/615483002/diff/1/components/password_manager/...
File
components/password_manager/content/browser/content_credential_manager_dispatcher.h
(right):

https://codereview.chromium.org/615483002/diff/1/components/password_manager/...
components/password_manager/content/browser/content_credential_manager_dispatcher.h:8:
#include "base/basictypes.h"
nit: Do you really need this, or just base/macros.h?

https://codereview.chromium.org/615483002/diff/1/components/password_manager/...
components/password_manager/content/browser/content_credential_manager_dispatcher.h:47:
PasswordManagerClient* client_;
Since |client_| does not appear to be used in the code yet, would you mind
adding a TODO comment explaining the plans (as an alternative to removing it
completely)?

https://codereview.chromium.org/615483002/diff/1/components/password_manager/...
File
components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc
(right):

https://codereview.chromium.org/615483002/diff/1/components/password_manager/...
components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc:37:
new ContentCredentialManagerDispatcher(web_contents(), nullptr));
Yaay++11! Thanks for making me check and realise all the awesomeness we got. :)

(No response needed. :))

[Mike West, 2014-09-29 11:21:03]

mkwst@chromium.org changed reviewers:
+ jochen@chromium.org

[Mike West, 2014-09-29 11:21:04]

Thanks Vaclav!

Jochen, would you mind stamping the change in chrome/browser? This patch is
basically removing functionality there, and moving it to the password_manager
component.

[Mike West, 2014-09-29 12:15:43]

mkwst@chromium.org changed reviewers:
- jochen@chromium.org

[Mike West, 2014-09-29 12:16:29]

Nevermind, Jochen. I didn't realize that vabr@ was an OWNER in
chrome/browser/password_manager/. :)

[Mike West, 2014-09-29 12:16:50]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2014-09-29 12:17:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/615483002/40001

[commit-bot: I haz the power, 2014-09-29 12:39:56]

Committed patchset #3 (id:40001) as c37e48e0492ad49a74ed1a8e0694171fcdde65ba

[commit-bot: I haz the power, 2014-09-29 12:40:30]

Patchset 3 (id:??) landed as
https://crrev.com/07f0d3dda6cb3d13f6116c778b02efb6a29ccae7
Cr-Commit-Position: refs/heads/master@{#297161}