Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

Issue 615483002: Credential Manager: Extract browser-side IPC to a stand-alone dispatcher. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/password_manager/chrome_password_manager_client.cc ('k') | components/components_tests.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
diff --git a/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc b/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
index f6d0a9e1fd5be0c9b253607424b1ede77b1b02b7..a69ee78295d70c289600f857a44deeca14219d2d 100644
--- a/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
+++ b/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
@@ -29,7 +29,6 @@ using content::WebContents;
namespace {
const char kTestText[] = "abcd1234";
-const int kRequestId = 4;
class MockLogReceiver : public password_manager::LogReceiver {
public:
@@ -331,62 +330,3 @@ TEST_F(ChromePasswordManagerClientTest,
"https://passwords.google.com&rart=234"));
EXPECT_TRUE(client->IsPasswordManagerEnabledForCurrentPage());
}
-
-TEST_F(ChromePasswordManagerClientTest, CredentialManagerOnNotifyFailedSignIn) {
- scoped_ptr<TestChromePasswordManagerClient> client(
- new TestChromePasswordManagerClient(web_contents()));
-
- password_manager::CredentialInfo info(base::ASCIIToUTF16("id"),
- base::ASCIIToUTF16("name"),
- GURL("https://example.com/image.png"));
- client->OnNotifyFailedSignIn(kRequestId, info);
-
- const uint32 kMsgID = CredentialManagerMsg_AcknowledgeFailedSignIn::ID;
- const IPC::Message* message =
- process()->sink().GetFirstMessageMatching(kMsgID);
- EXPECT_TRUE(message);
- process()->sink().ClearMessages();
-}
-
-TEST_F(ChromePasswordManagerClientTest, CredentialManagerOnNotifySignedIn) {
- scoped_ptr<TestChromePasswordManagerClient> client(
- new TestChromePasswordManagerClient(web_contents()));
-
- password_manager::CredentialInfo info(base::ASCIIToUTF16("id"),
- base::ASCIIToUTF16("name"),
- GURL("https://example.com/image.png"));
- client->OnNotifySignedIn(kRequestId, info);
-
- const uint32 kMsgID = CredentialManagerMsg_AcknowledgeSignedIn::ID;
- const IPC::Message* message =
- process()->sink().GetFirstMessageMatching(kMsgID);
- EXPECT_TRUE(message);
- process()->sink().ClearMessages();
-}
-
-TEST_F(ChromePasswordManagerClientTest, CredentialManagerOnNotifySignedOut) {
- scoped_ptr<TestChromePasswordManagerClient> client(
- new TestChromePasswordManagerClient(web_contents()));
-
- client->OnNotifySignedOut(kRequestId);
-
- const uint32 kMsgID = CredentialManagerMsg_AcknowledgeSignedOut::ID;
- const IPC::Message* message =
- process()->sink().GetFirstMessageMatching(kMsgID);
- EXPECT_TRUE(message);
- process()->sink().ClearMessages();
-}
-
-TEST_F(ChromePasswordManagerClientTest, CredentialManagerOnRequestCredential) {
- scoped_ptr<TestChromePasswordManagerClient> client(
- new TestChromePasswordManagerClient(web_contents()));
-
- std::vector<GURL> federations;
- client->OnRequestCredential(kRequestId, false, federations);
-
- const uint32 kMsgID = CredentialManagerMsg_SendCredential::ID;
- const IPC::Message* message =
- process()->sink().GetFirstMessageMatching(kMsgID);
- EXPECT_TRUE(message);
- process()->sink().ClearMessages();
-}
« no previous file with comments | « chrome/browser/password_manager/chrome_password_manager_client.cc ('k') | components/components_tests.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698