Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.cc

Issue 615483002: Credential Manager: Extract browser-side IPC to a stand-alone dispatcher. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/chrome_password_manager_client.cc
diff --git a/chrome/browser/password_manager/chrome_password_manager_client.cc b/chrome/browser/password_manager/chrome_password_manager_client.cc
index 159bd3b0089bf1d9976b06162b2b979bc5328262..a6e032a5af3fa704420d610157419c4faac839bb 100644
--- a/chrome/browser/password_manager/chrome_password_manager_client.cc
+++ b/chrome/browser/password_manager/chrome_password_manager_client.cc
@@ -69,6 +69,7 @@ ChromePasswordManagerClient::ChromePasswordManagerClient(
: content::WebContentsObserver(web_contents),
profile_(Profile::FromBrowserContext(web_contents->GetBrowserContext())),
driver_(web_contents, this, autofill_client),
+ credential_manager_dispatcher_(web_contents, this),
observer_(NULL),
can_use_log_router_(false),
autofill_sync_state_(ALLOW_SYNC_CREDENTIALS),
@@ -295,46 +296,6 @@ bool ChromePasswordManagerClient::IsLoggingActive() const {
return can_use_log_router_ && !web_contents()->GetWebUI();
}
-void ChromePasswordManagerClient::OnNotifyFailedSignIn(
- int request_id,
- const password_manager::CredentialInfo&) {
- // TODO(mkwst): This is a stub.
- web_contents()->GetRenderViewHost()->Send(
- new CredentialManagerMsg_AcknowledgeFailedSignIn(
- web_contents()->GetRenderViewHost()->GetRoutingID(), request_id));
-}
-
-void ChromePasswordManagerClient::OnNotifySignedIn(
- int request_id,
- const password_manager::CredentialInfo&) {
- // TODO(mkwst): This is a stub.
- web_contents()->GetRenderViewHost()->Send(
- new CredentialManagerMsg_AcknowledgeSignedIn(
- web_contents()->GetRenderViewHost()->GetRoutingID(), request_id));
-}
-
-void ChromePasswordManagerClient::OnNotifySignedOut(int request_id) {
- // TODO(mkwst): This is a stub.
- web_contents()->GetRenderViewHost()->Send(
- new CredentialManagerMsg_AcknowledgeSignedOut(
- web_contents()->GetRenderViewHost()->GetRoutingID(), request_id));
-}
-
-void ChromePasswordManagerClient::OnRequestCredential(
- int request_id,
- bool zero_click_only,
- const std::vector<GURL>& federations) {
- // TODO(mkwst): This is a stub.
- password_manager::CredentialInfo info(base::ASCIIToUTF16("id"),
- base::ASCIIToUTF16("name"),
- GURL("https://example.com/image.png"));
- web_contents()->GetRenderViewHost()->Send(
- new CredentialManagerMsg_SendCredential(
- web_contents()->GetRenderViewHost()->GetRoutingID(),
- request_id,
- info));
-}
-
// static
password_manager::PasswordGenerationManager*
ChromePasswordManagerClient::GetGenerationManagerFromWebContents(
@@ -376,16 +337,6 @@ bool ChromePasswordManagerClient::OnMessageReceived(
IPC_MESSAGE_HANDLER(AutofillHostMsg_PasswordAutofillAgentConstructed,
NotifyRendererOfLoggingAvailability)
- // Credential Manager messages:
- IPC_MESSAGE_HANDLER(CredentialManagerHostMsg_NotifyFailedSignIn,
- OnNotifyFailedSignIn);
- IPC_MESSAGE_HANDLER(CredentialManagerHostMsg_NotifySignedIn,
- OnNotifySignedIn);
- IPC_MESSAGE_HANDLER(CredentialManagerHostMsg_NotifySignedOut,
- OnNotifySignedOut);
- IPC_MESSAGE_HANDLER(CredentialManagerHostMsg_RequestCredential,
- OnRequestCredential);
-
// Default:
IPC_MESSAGE_UNHANDLED(handled = false)
IPC_END_MESSAGE_MAP()

Powered by Google App Engine
This is Rietveld 408576698