content/common/gpu/media/video_encode_accelerator_unittest.cc - Issue 614893004: Refactor AppendToFile and WriteFileDescriptor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/media/video_encode_accelerator_unittest.cc

Issue 614893004: Refactor AppendToFile and WriteFileDescriptor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address nits Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/gpu/media/video_encode_accelerator_unittest.cc

diff --git a/content/common/gpu/media/video_encode_accelerator_unittest.cc b/content/common/gpu/media/video_encode_accelerator_unittest.cc

index 60bc875e96aa648c00783897a815fd3889290e9a..481091558205a842040b86588ea48fe52305a906 100644

--- a/content/common/gpu/media/video_encode_accelerator_unittest.cc

+++ b/content/common/gpu/media/video_encode_accelerator_unittest.cc

@@ -825,11 +825,10 @@ void VEAClient::BitstreamBufferReady(int32 bitstream_buffer_id,

if (save_to_file_) {

int size = base::checked_cast<int>(payload_size);

- EXPECT_EQ(base::AppendToFile(

- base::FilePath::FromUTF8Unsafe(test_stream_->out_filename),

- static_cast<char*>(shm->memory()),

- size),

- size);

+ EXPECT_TRUE(base::AppendToFile(

+ base::FilePath::FromUTF8Unsafe(test_stream_->out_filename),

+ static_cast<char*>(shm->memory()),

+ size));

}

FeedEncoderWithOutput(shm);