content/common/gpu/media/vaapi_h264_decoder_unittest.cc - Issue 614893004: Refactor AppendToFile and WriteFileDescriptor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/media/vaapi_h264_decoder_unittest.cc

Issue 614893004: Refactor AppendToFile and WriteFileDescriptor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address nits Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/gpu/media/vaapi_h264_decoder_unittest.cc

diff --git a/content/common/gpu/media/vaapi_h264_decoder_unittest.cc b/content/common/gpu/media/vaapi_h264_decoder_unittest.cc

index 41bbbbc2056cc0665664bfcf45fd38907f176c6a..70d8220ddbe2c494788a52294a830680c1494cfd 100644

--- a/content/common/gpu/media/vaapi_h264_decoder_unittest.cc

+++ b/content/common/gpu/media/vaapi_h264_decoder_unittest.cc

@@ -249,8 +249,7 @@ bool VaapiH264DecoderLoop::ProcessVideoFrame(

int to_write = media::VideoFrame::PlaneAllocationSize(

frame->format(), i, frame->coded_size());

const char* buf = reinterpret_cast<const char*>(frame->data(i));

- int written = base::AppendToFile(output_file_, buf, to_write);

- if (written != to_write)

+ if (!base::AppendToFile(output_file_, buf, to_write))

return false;

}

return true;