media/cast/test/simulator.cc - Issue 614893004: Refactor AppendToFile and WriteFileDescriptor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/cast/test/simulator.cc

Issue 614893004: Refactor AppendToFile and WriteFileDescriptor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address nits Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/cast/test/simulator.cc

diff --git a/media/cast/test/simulator.cc b/media/cast/test/simulator.cc

index e3872a98d98ce952d9b264318704a66073e7ba2d..cccc571a21532c66d5cbdbee73f9b4b8c2c7a6c9 100644

--- a/media/cast/test/simulator.cc

+++ b/media/cast/test/simulator.cc

@@ -186,7 +186,7 @@ void AppendLogToFile(media::cast::proto::LogMetadata* metadata,

return;

}

- if (AppendToFile(output_path, serialized_log.get(), output_bytes) == -1) {

+ if (!AppendToFile(output_path, serialized_log.get(), output_bytes)) {

LOG(ERROR) << "Failed to append to log.";

}