components/policy/core/common/policy_loader_win_unittest.cc - Issue 614893004: Refactor AppendToFile and WriteFileDescriptor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/policy_loader_win_unittest.cc

Issue 614893004: Refactor AppendToFile and WriteFileDescriptor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address nits Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/policy/core/common/policy_loader_win_unittest.cc

diff --git a/components/policy/core/common/policy_loader_win_unittest.cc b/components/policy/core/common/policy_loader_win_unittest.cc

index 88205b4a67a879f42a35179880606d50809d55ab..227997cae7f1a7b3296e80066b78be7a377247e1 100644

--- a/components/policy/core/common/policy_loader_win_unittest.cc

+++ b/components/policy/core/common/policy_loader_win_unittest.cc

@@ -588,11 +588,10 @@ void PRegTestHarness::AppendRecordToPRegFile(const base::string16& path,

buffer.insert(buffer.end(), data, data + size);

AppendChars(&buffer, L"]");

- ASSERT_EQ(buffer.size(),

- base::AppendToFile(

- preg_file_path_,

- reinterpret_cast<const char*>(vector_as_array(&buffer)),

- buffer.size()));

+ ASSERT_TRUE(base::AppendToFile(

+ preg_file_path_,

+ reinterpret_cast<const char*>(vector_as_array(&buffer)),

+ buffer.size()));

}

void PRegTestHarness::AppendDWORDToPRegFile(const base::string16& path,