chrome/browser/devtools/devtools_file_helper.cc - Issue 614893004: Refactor AppendToFile and WriteFileDescriptor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/devtools_file_helper.cc

Issue 614893004: Refactor AppendToFile and WriteFileDescriptor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address nits Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/devtools/devtools_file_helper.cc

diff --git a/chrome/browser/devtools/devtools_file_helper.cc b/chrome/browser/devtools/devtools_file_helper.cc

index da780346450e5229e72eabae65118cf10e0abc54..04ab843e1c9650a179f76fb3328072ae909eeac4 100644

--- a/chrome/browser/devtools/devtools_file_helper.cc

+++ b/chrome/browser/devtools/devtools_file_helper.cc

@@ -128,7 +128,7 @@ void AppendToFile(const base::FilePath& path, const std::string& content) {

DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));

DCHECK(!path.empty());

- base::AppendToFile(path, content.c_str(), content.length());

+ base::AppendToFile(path, content.c_str(), content.size());

}

storage::IsolatedContext* isolated_context() {

« no previous file with comments | « base/test/trace_to_file.cc ('k') | chrome/browser/media/webrtc_rtp_dump_writer.cc » ('j') | no next file with comments »