Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Side by Side Diff: chrome/browser/devtools/devtools_file_helper.cc

Issue 614893004: Refactor AppendToFile and WriteFileDescriptor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address nits Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/test/trace_to_file.cc ('k') | chrome/browser/media/webrtc_rtp_dump_writer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/devtools/devtools_file_helper.h" 5 #include "chrome/browser/devtools/devtools_file_helper.h"
6 6
7 #include <set> 7 #include <set>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE)); 121 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
122 DCHECK(!path.empty()); 122 DCHECK(!path.empty());
123 123
124 base::WriteFile(path, content.c_str(), content.length()); 124 base::WriteFile(path, content.c_str(), content.length());
125 } 125 }
126 126
127 void AppendToFile(const base::FilePath& path, const std::string& content) { 127 void AppendToFile(const base::FilePath& path, const std::string& content) {
128 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE)); 128 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
129 DCHECK(!path.empty()); 129 DCHECK(!path.empty());
130 130
131 base::AppendToFile(path, content.c_str(), content.length()); 131 base::AppendToFile(path, content.c_str(), content.size());
132 } 132 }
133 133
134 storage::IsolatedContext* isolated_context() { 134 storage::IsolatedContext* isolated_context() {
135 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 135 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
136 storage::IsolatedContext* isolated_context = 136 storage::IsolatedContext* isolated_context =
137 storage::IsolatedContext::GetInstance(); 137 storage::IsolatedContext::GetInstance();
138 DCHECK(isolated_context); 138 DCHECK(isolated_context);
139 return isolated_context; 139 return isolated_context;
140 } 140 }
141 141
(...skipping 277 matching lines...) Expand 10 before | Expand all | Expand 10 after
419 base::DictionaryValue* file_systems_paths_value = update.Get(); 419 base::DictionaryValue* file_systems_paths_value = update.Get();
420 file_systems_paths_value->RemoveWithoutPathExpansion(file_system_path, NULL); 420 file_systems_paths_value->RemoveWithoutPathExpansion(file_system_path, NULL);
421 } 421 }
422 422
423 bool DevToolsFileHelper::IsFileSystemAdded( 423 bool DevToolsFileHelper::IsFileSystemAdded(
424 const std::string& file_system_path) { 424 const std::string& file_system_path) {
425 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 425 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
426 set<std::string> file_system_paths = GetAddedFileSystemPaths(profile_); 426 set<std::string> file_system_paths = GetAddedFileSystemPaths(profile_);
427 return file_system_paths.find(file_system_path) != file_system_paths.end(); 427 return file_system_paths.find(file_system_path) != file_system_paths.end();
428 } 428 }
OLDNEW
« no previous file with comments | « base/test/trace_to_file.cc ('k') | chrome/browser/media/webrtc_rtp_dump_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698