base/test/trace_to_file.cc - Issue 614893004: Refactor AppendToFile and WriteFileDescriptor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/test/trace_to_file.cc

Issue 614893004: Refactor AppendToFile and WriteFileDescriptor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address nits Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/test/trace_to_file.cc

diff --git a/base/test/trace_to_file.cc b/base/test/trace_to_file.cc

index 6caaf47af32bbf3feedd17bce2a1e5af9272d500..423f65c125dc610717a0ccf293aa5e5343aea213 100644

--- a/base/test/trace_to_file.cc

+++ b/base/test/trace_to_file.cc

@@ -67,8 +67,8 @@ void TraceToFile::AppendFileFooter() {

}

void TraceToFile::TraceOutputCallback(const std::string& data) {

- int ret = AppendToFile(path_, data.c_str(), static_cast<int>(data.size()));

- DCHECK_NE(-1, ret);

+ bool ret = AppendToFile(path_, data.c_str(), static_cast<int>(data.size()));

+ DCHECK(ret);

}

static void OnTraceDataCollected(

« no previous file with comments | « base/sync_socket_posix.cc ('k') | chrome/browser/devtools/devtools_file_helper.cc » ('j') | no next file with comments »