Relax representation requirement in FrameStates.

Relax representation requirement in FrameStates.

This change enables non-tagged representations in FrameStates.

That allows us to run zlib with deoptimization support and have almost the same performance of the generated code (as the code with no deoptimization). Unfortunately, the frame states seem to confuse typer. As a consequence, we generate more representation changes, which in turn causes the scheduler to take a lot more time and memory (>4x). The added compiler time makes zlib with deopt be about 50% slower.

BUG=
R=titzer@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=24454

[Jarin, 2014-10-02 13:14:18]

jarin@chromium.org changed reviewers:
+ titzer@chromium.org

[Jarin, 2014-10-02 13:14:43]

Could you take a look, please?

[titzer, 2014-10-06 08:54:11]

https://codereview.chromium.org/614713002/diff/80001/src/compiler/instruction.h
File src/compiler/instruction.h (right):

https://codereview.chromium.org/614713002/diff/80001/src/compiler/instruction...
src/compiler/instruction.h:736: void SetTypes(ZoneVector<MachineType>* types);
The types vector only describes this frame state's types, correct? If so, its
size should be determinable from the parameters, locals, and stack count. Can we
allocate the vector here and offer peek/poke methods into it?

[titzer, 2014-10-06 08:56:02]

https://codereview.chromium.org/614713002/diff/80001/src/compiler/code-genera...
File src/compiler/code-generator.cc (right):

https://codereview.chromium.org/614713002/diff/80001/src/compiler/code-genera...
src/compiler/code-generator.cc:415: DCHECK_EQ(kRepFloat64, type & kRepMask);
You probably need to account for float32 here as well.

https://codereview.chromium.org/614713002/diff/80001/src/compiler/code-genera...
src/compiler/code-generator.cc:430: DCHECK_EQ(kRepFloat64, type & kRepMask);
And here.

[Jarin, 2014-10-06 09:45:27]

Done as suggested. Thanks!

https://codereview.chromium.org/614713002/diff/80001/src/compiler/code-genera...
File src/compiler/code-generator.cc (right):

https://codereview.chromium.org/614713002/diff/80001/src/compiler/code-genera...
src/compiler/code-generator.cc:415: DCHECK_EQ(kRepFloat64, type & kRepMask);
On 2014/10/06 08:56:02, titzer wrote:
> You probably need to account for float32 here as well.

Done.

https://codereview.chromium.org/614713002/diff/80001/src/compiler/code-genera...
src/compiler/code-generator.cc:430: DCHECK_EQ(kRepFloat64, type & kRepMask);
On 2014/10/06 08:56:01, titzer wrote:
> And here.

Done.

https://codereview.chromium.org/614713002/diff/80001/src/compiler/instruction.h
File src/compiler/instruction.h (right):

https://codereview.chromium.org/614713002/diff/80001/src/compiler/instruction...
src/compiler/instruction.h:736: void SetTypes(ZoneVector<MachineType>* types);
On 2014/10/06 08:54:11, titzer wrote:
> The types vector only describes this frame state's types, correct? If so, its
> size should be determinable from the parameters, locals, and stack count. Can
we
> allocate the vector here and offer peek/poke methods into it?

Done.

[Jarin, 2014-10-08 08:11:07]

ping.

[titzer, 2014-10-08 08:20:37]

lgtm

[Jarin, 2014-10-08 08:47:43]

Committed patchset #7 (id:120001) manually as 24454 (presubmit successful).