Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 614173003: Remove the disallowFullscreenForNonMediaElements setting. (Closed)

Created:
6 years, 2 months ago by Ignacio Solla
Modified:
6 years, 2 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, jamesr, mkwst+moarreviews_chromium.org, Mike West, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove the disallowFullscreenForNonMediaElements setting. This setting will not longer be used after: https://codereview.chromium.org/618013003/ It will be landed after that change. BUG=398485 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183900

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Remove the tests for this setting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -49 lines) Patch
D LayoutTests/fullscreen/full-screen-request-disallow-for-non-media-elements.html View 1 2 1 chunk +0 lines, -22 lines 0 comments Download
D LayoutTests/fullscreen/full-screen-request-disallow-for-non-media-elements-expected.txt View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/dom/Fullscreen.cpp View 1 2 chunks +1 line, -8 lines 0 comments Download
M Source/core/frame/Settings.in View 1 1 chunk +0 lines, -8 lines 0 comments Download
M Source/web/WebSettingsImpl.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebSettingsImpl.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M public/web/WebSettings.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
Ignacio Solla
jochen@chromium.org: Please review all changes
6 years, 2 months ago (2014-10-02 12:28:52 UTC) #3
jochen (gone - plz use gerrit)
lgtm
6 years, 2 months ago (2014-10-02 12:34:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/614173003/20001
6 years, 2 months ago (2014-10-16 15:58:33 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/29538)
6 years, 2 months ago (2014-10-16 17:04:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/614173003/40001
6 years, 2 months ago (2014-10-17 14:44:10 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 16:23:46 UTC) #11
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as 183900

Powered by Google App Engine
This is Rietveld 408576698