Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Side by Side Diff: Source/core/frame/Settings.in

Issue 614173003: Remove the disallowFullscreenForNonMediaElements setting. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Remove the tests for this setting Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/dom/Fullscreen.cpp ('k') | Source/web/WebSettingsImpl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Defines properties which are available on the Settings object. 1 # Defines properties which are available on the Settings object.
2 # 2 #
3 # Please think carefully before adding a new Setting. Some questions to 3 # Please think carefully before adding a new Setting. Some questions to
4 # consider are: 4 # consider are:
5 # - Should this be a RuntimeEnabledFeature instead? Settings are for things 5 # - Should this be a RuntimeEnabledFeature instead? Settings are for things
6 # which we support either values of at runtime. Features are set at renderer 6 # which we support either values of at runtime. Features are set at renderer
7 # process startup and are never changed. Features also tend to be set to a 7 # process startup and are never changed. Features also tend to be set to a
8 # value based on the platform or the stability of the code in question, where 8 # value based on the platform or the stability of the code in question, where
9 # as settings both codepaths need to be stable. 9 # as settings both codepaths need to be stable.
10 # - How will you ensure test coverage of all relevant values of your setting? 10 # - How will you ensure test coverage of all relevant values of your setting?
(...skipping 259 matching lines...) Expand 10 before | Expand all | Expand 10 after
270 # does not proscribe an upper limit, but allows for it -- the underlying 270 # does not proscribe an upper limit, but allows for it -- the underlying
271 # API will return 'false' in that case. 271 # API will return 'false' in that case.
272 maxBeaconTransmission type=int, initial=65536 272 maxBeaconTransmission type=int, initial=65536
273 273
274 # This value is set to false if the platform does not support fullscreen. 274 # This value is set to false if the platform does not support fullscreen.
275 # When set to false all the requests to enter fullscreen will return an error 275 # When set to false all the requests to enter fullscreen will return an error
276 # (fullscreenerror or webkitfullscreenerror) as specified in the standard: 276 # (fullscreenerror or webkitfullscreenerror) as specified in the standard:
277 # http://fullscreen.spec.whatwg.org/#dom-element-requestfullscreen 277 # http://fullscreen.spec.whatwg.org/#dom-element-requestfullscreen
278 fullscreenSupported initial=true 278 fullscreenSupported initial=true
279 279
280 # FIXME: This is a temporary flag and should be removed once
281 # the Android WebView framework supports fullscreen for non-media elements
282 # (crbug.com/398485).
283 # This value is set to false if the platform does not support fullscreen
284 # for non-media elements. When set to true all the requests to enter fullscreen
285 # on non-media elements will return an error.
286 disallowFullscreenForNonMediaElements initial=false
287
288 # V8 supports different types of caching. Used by V8 bindings. 280 # V8 supports different types of caching. Used by V8 bindings.
289 v8CacheOptions type=V8CacheOptions, initial=V8CacheOptionsOff 281 v8CacheOptions type=V8CacheOptions, initial=V8CacheOptionsOff
290 282
291 v8ScriptStreamingEnabled initial=false 283 v8ScriptStreamingEnabled initial=false
292 284
293 # These values are bit fields for the properties of available pointing devices 285 # These values are bit fields for the properties of available pointing devices
294 # and may take on multiple values (e.g. laptop with touchpad and touchscreen 286 # and may take on multiple values (e.g. laptop with touchpad and touchscreen
295 # has pointerType coarse *and* fine). 287 # has pointerType coarse *and* fine).
296 availablePointerTypes type=int, initial=PointerTypeNone, invalidate=MediaQuery 288 availablePointerTypes type=int, initial=PointerTypeNone, invalidate=MediaQuery
297 availableHoverTypes type=int, initial=HoverTypeNone, invalidate=MediaQuery 289 availableHoverTypes type=int, initial=HoverTypeNone, invalidate=MediaQuery
298 290
299 # These values specify properties of the user's primary pointing device only. 291 # These values specify properties of the user's primary pointing device only.
300 primaryPointerType type=PointerType, initial=PointerTypeNone, invalidate=MediaQu ery 292 primaryPointerType type=PointerType, initial=PointerTypeNone, invalidate=MediaQu ery
301 primaryHoverType type=HoverType, initial=HoverTypeNone, invalidate=MediaQuery 293 primaryHoverType type=HoverType, initial=HoverTypeNone, invalidate=MediaQuery
302 294
303 accessibilityEnabled initial=false, invalidate=AccessibilityState 295 accessibilityEnabled initial=false, invalidate=AccessibilityState
304 inlineTextBoxAccessibilityEnabled initial=false 296 inlineTextBoxAccessibilityEnabled initial=false
OLDNEW
« no previous file with comments | « Source/core/dom/Fullscreen.cpp ('k') | Source/web/WebSettingsImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698