Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Unified Diff: Source/core/dom/Fullscreen.cpp

Issue 614173003: Remove the disallowFullscreenForNonMediaElements setting. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Remove the tests for this setting Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/Fullscreen.cpp
diff --git a/Source/core/dom/Fullscreen.cpp b/Source/core/dom/Fullscreen.cpp
index 19178d3ab8320ce88d01762fa2f3abd001195673..0328c519de1771cd7ca894deb4ae30f174afc5c8 100644
--- a/Source/core/dom/Fullscreen.cpp
+++ b/Source/core/dom/Fullscreen.cpp
@@ -65,13 +65,6 @@ static bool fullscreenIsSupported(const Document& document)
return !document.settings() || document.settings()->fullscreenSupported();
}
-static bool fullscreenIsSupported(const Document& document, const Element& element)
-{
- if (!document.settings() || (document.settings()->disallowFullscreenForNonMediaElements() && !isHTMLMediaElement(element)))
- return false;
- return fullscreenIsSupported(document);
-}
-
static bool fullscreenElementReady(const Element& element, Fullscreen::RequestType requestType)
{
// A fullscreen element ready check for an element |element| returns true if all of the
@@ -240,7 +233,7 @@ void Fullscreen::requestFullscreen(Element& element, RequestType requestType)
}
// Fullscreen is not supported.
- if (!fullscreenIsSupported(element.document(), element))
+ if (!fullscreenIsSupported(element.document()))
break;
// 2. Let doc be element's node document. (i.e. "this")
« no previous file with comments | « LayoutTests/fullscreen/full-screen-request-disallow-for-non-media-elements-expected.txt ('k') | Source/core/frame/Settings.in » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698