Make WindowState::CanMinimize() take into account WidgetDelegate::CanMinimize()

ash/wm/window_state.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/window_state.h"
 
 #include "ash/ash_switches.h"
 #include "ash/root_window_controller.h"
 #include "ash/screen_util.h"
 #include "ash/shell_window_ids.h"
@@ skipping 135 matching lines @@
     return false;
 
   if (!window()->delegate())
     return true;
 
   gfx::Size max_size = window_->delegate()->GetMaximumSize();
   return !max_size.width() && !max_size.height();
 }
 
 bool WindowState::CanMinimize() const {
-  RootWindowController* controller = RootWindowController::ForWindow(window_);
-  if (!controller)
-    return false;
-  aura::Window* lockscreen =
-      controller->GetContainer(kShellWindowId_LockScreenContainersContainer);
-  if (lockscreen->Contains(window_))
-    return false;

[oshima, 2014/09/29 18:32:20]

Loosk like I moved this from window_util.h in

https://chromiumcodereview.appspot.com/24108003/

but couldn't tell why. Do you know why this is done this way? 

and where are you handling this in new CL?

[pkotwicz, 2014/09/30 14:48:21]

This code was added to prevent touch gestures from minimizing windows in the
login screen (https://codereview.chromium.org/12220026).

This code is not needed anymore thanks to
https://codereview.chromium.org/583603004/ because WebDialogView does not
override views::WidgetDelegate::CanMinimize()

This is pretty subtle so I have added LoginWebDialogTest

Thank you for pointing out that this is confusing!

-
-  return true;
+  return window()->GetProperty(aura::client::kCanMinimizeKey);
 }
 
 bool WindowState::CanResize() const {
   return window_->GetProperty(aura::client::kCanResizeKey);
 }
 
 bool WindowState::CanActivate() const {
   return ::wm::CanActivateWindow(window_);
 }
 
@@ skipping 283 matching lines @@
   }
   return settings;
 }
 
 const WindowState* GetWindowState(const aura::Window* window) {
   return GetWindowState(const_cast<aura::Window*>(window));
 }
 
 }  // namespace wm
 }  // namespace ash