Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 12220026: ash: Do not allow minimizing windows in login screen. (Closed)

Created:
7 years, 10 months ago by sadrul
Modified:
7 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

ash: Do not allow minimizing windows in login screen. Minimizing windows (e.g. network proxy window) in a login screen do not make much sense. And it causes unpredictable behaviour. So do not allow minimizing windows in login screen. BUG=167386 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180900

Patch Set 1 : . #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : . #

Patch Set 4 : add-test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -8 lines) Patch
M ash/accelerators/accelerator_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/root_window_controller.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/root_window_controller.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ash/wm/gestures/two_finger_drag_handler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ash/wm/property_util.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/property_util.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/toplevel_window_event_handler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ash/wm/toplevel_window_event_handler_unittest.cc View 1 2 3 4 chunks +36 lines, -1 line 0 comments Download
M ash/wm/window_util.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/wm/window_util.cc View 1 2 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sadrul
Hi! Does this look like a reasonable approach for fixing this? I can add tests ...
7 years, 10 months ago (2013-02-06 00:14:22 UTC) #1
sky
https://codereview.chromium.org/12220026/diff/6001/ash/wm/window_util.cc File ash/wm/window_util.cc (right): https://codereview.chromium.org/12220026/diff/6001/ash/wm/window_util.cc#newcode73 ash/wm/window_util.cc:73: internal::RootWindowController::ForActiveRootWindow(); Shouldn't this lookup the RWC based on |window|?
7 years, 10 months ago (2013-02-06 00:38:42 UTC) #2
sadrul
https://codereview.chromium.org/12220026/diff/6001/ash/wm/window_util.cc File ash/wm/window_util.cc (right): https://codereview.chromium.org/12220026/diff/6001/ash/wm/window_util.cc#newcode73 ash/wm/window_util.cc:73: internal::RootWindowController::ForActiveRootWindow(); On 2013/02/06 00:38:42, sky wrote: > Shouldn't this ...
7 years, 10 months ago (2013-02-06 00:57:39 UTC) #3
sky
7 years, 10 months ago (2013-02-06 01:06:31 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698