Add CanMinimize to classes that implement WidgetDelegate::CanMaximize.

Add CanMinimize to classes that implement WidgetDelegate::CanMaximize.

There were some cases where we use CanMaximize to determine if
minimization should be disabled. They now use CanMinimize:
- custom_frame_view_ash
- hwnd_message_handler

All classes that implement CanMaximize now implement
CanMinimize in the same way, so there should no change in
behavior.

BUG=328241, 341010
Committed: https://crrev.com/3fdb73284d2b947f3a81ebe81501635b220b4dc1
Cr-Commit-Position: refs/heads/master@{#296381}

[jackhou1, 2014-09-21 05:51:30]

jackhou@chromium.org changed reviewers:
+ sky@chromium.org

[jackhou1, 2014-09-21 05:51:31]

sky, could you take a look at this?

[pkotwicz, 2014-09-22 00:32:17]

Can you please also update WindowState::CanMinimize()

[pkotwicz, 2014-09-22 01:09:00]

pkotwicz@chromium.org changed reviewers:
+ pkotwicz@chromium.org

[pkotwicz, 2014-09-22 01:09:00]

https://codereview.chromium.org/583603004/diff/40001/ash/frame/custom_frame_v...
File ash/frame/custom_frame_view_ash.cc (right):

https://codereview.chromium.org/583603004/diff/40001/ash/frame/custom_frame_v...
ash/frame/custom_frame_view_ash.cc:206: // that the window frame can be
minimized if it can be maximized.
This comment is no longer true

[jackhou1, 2014-09-22 02:59:48]

> Can you please also update WindowState::CanMinimize()

I'm not really sure how this should be done. It might require a new window
property like aura::client::kCanMinimizeKey, which would get set in
NativeWidgetAura::OnSizeConstraintsChanged. Probably better to do this in
another CL.

https://codereview.chromium.org/583603004/diff/40001/ash/frame/custom_frame_v...
File ash/frame/custom_frame_view_ash.cc (right):

https://codereview.chromium.org/583603004/diff/40001/ash/frame/custom_frame_v...
ash/frame/custom_frame_view_ash.cc:206: // that the window frame can be
minimized if it can be maximized.
On 2014/09/22 01:09:00, pkotwicz wrote:
> This comment is no longer true

Done.

[sky, 2014-09-22 16:27:18]

LGTM

[jackhou1, 2014-09-23 00:37:00]

jackhou@chromium.org changed reviewers:
+ jamescook@chromium.org, pfeldman@chromium.org

[jackhou1, 2014-09-23 00:37:01]

pfeldman, please review for OWNERS in content/shell/

jamescook, please review for OWNERS in components/native_app_window/

[James Cook, 2014-09-23 00:57:54]

https://codereview.chromium.org/583603004/diff/80001/components/native_app_wi...
File components/native_app_window/native_app_window_views.cc (right):

https://codereview.chromium.org/583603004/diff/80001/components/native_app_wi...
components/native_app_window/native_app_window_views.cc:222: return true;
Is this right?  All views app windows opened by chrome.app.window.create() can
be minimized?

(Also, should you be an owner of this directory? I see you are an owner of the
app_window API.  Feel free to add yourself.)

[jackhou1, 2014-09-23 01:28:48]

https://codereview.chromium.org/583603004/diff/80001/components/native_app_wi...
File components/native_app_window/native_app_window_views.cc (right):

https://codereview.chromium.org/583603004/diff/80001/components/native_app_wi...
components/native_app_window/native_app_window_views.cc:222: return true;
On 2014/09/23 00:57:53, James Cook wrote:
> Is this right?  All views app windows opened by chrome.app.window.create() can
> be minimized?

Yeah, I think that's what we want. It's not how it currently behaves, largely
due to not having a CanMinimize().

That said, I should stick to the CL description and leave behavior unchanged in
this CL.

[James Cook, 2014-09-23 16:18:02]

LGTM

https://codereview.chromium.org/583603004/diff/100001/components/native_app_w...
File components/native_app_window/native_app_window_views.cc (right):

https://codereview.chromium.org/583603004/diff/100001/components/native_app_w...
components/native_app_window/native_app_window_views.cc:222: return
CanMaximize();
nit: You might add a TODO here if you think this should be "true".  Now that I
think about it more that seems reasonable.

[jackhou1, 2014-09-24 00:49:19]

https://codereview.chromium.org/583603004/diff/100001/components/native_app_w...
File components/native_app_window/native_app_window_views.cc (right):

https://codereview.chromium.org/583603004/diff/100001/components/native_app_w...
components/native_app_window/native_app_window_views.cc:222: return
CanMaximize();
On 2014/09/23 16:18:02, James Cook OOO until 9-29 wrote:
> nit: You might add a TODO here if you think this should be "true".  Now that I
> think about it more that seems reasonable.

Done.

[jackhou1, 2014-09-24 00:56:13]

jackhou@chromium.org changed reviewers:
+ creis@chromium.org

[jackhou1, 2014-09-24 00:56:14]

pfeldman, ping

+creis in case pfeldman is busy.

[pfeldman, 2014-09-24 09:26:35]

shell lgtm

[jackhou1, 2014-09-24 09:46:34]

The CQ bit was checked by jackhou@chromium.org

[commit-bot: I haz the power, 2014-09-24 09:47:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/583603004/120001

[commit-bot: I haz the power, 2014-09-24 10:25:56]

Committed patchset #7 (id:120001) as 1fec03cd5f4c31de624883eae291555a974c2847

[commit-bot: I haz the power, 2014-09-24 10:26:39]

Patchset 7 (id:??) landed as
https://crrev.com/3fdb73284d2b947f3a81ebe81501635b220b4dc1
Cr-Commit-Position: refs/heads/master@{#296381}