Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 6122009: Add FLAC to trunk/deps/third_party/.... (Closed)

Created:
9 years, 11 months ago by Satish
Modified:
9 years, 7 months ago
Reviewers:
Peter Kasting, M-A Ruel
CC:
chromium-reviews
Visibility:
Public.

Description

Add FLAC to trunk/deps/third_party/. This will be used for compressing and transmitting recorded audio for speech recognition in a subsequent CL. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71053

Patch Set 1 : '' #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25254 lines, -0 lines) Patch
A flac/AUTHORS View 1 1 chunk +41 lines, -0 lines 0 comments Download
A flac/COPYING.FDL View 1 1 chunk +397 lines, -0 lines 0 comments Download
A flac/COPYING.GPL View 1 1 chunk +340 lines, -0 lines 0 comments Download
A flac/COPYING.LGPL View 1 1 chunk +504 lines, -0 lines 0 comments Download
A flac/COPYING.Xiph View 1 1 chunk +28 lines, -0 lines 0 comments Download
A flac/README View 1 1 chunk +254 lines, -0 lines 0 comments Download
A flac/README.chromium View 1 1 chunk +12 lines, -0 lines 0 comments Download
A flac/flac.h View 1 1 chunk +14 lines, -0 lines 0 comments Download
A flac/flac.gyp View 1 1 chunk +80 lines, -0 lines 0 comments Download
A flac/include/FLAC/all.h View 1 1 chunk +370 lines, -0 lines 0 comments Download
A flac/include/FLAC/assert.h View 1 1 chunk +45 lines, -0 lines 0 comments Download
A flac/include/FLAC/callback.h View 1 1 chunk +184 lines, -0 lines 0 comments Download
A flac/include/FLAC/export.h View 1 1 chunk +91 lines, -0 lines 0 comments Download
A flac/include/FLAC/format.h View 1 1 chunk +1010 lines, -0 lines 0 comments Download
A flac/include/FLAC/metadata.h View 1 1 chunk +2181 lines, -0 lines 0 comments Download
A flac/include/FLAC/ordinals.h View 1 1 chunk +80 lines, -0 lines 0 comments Download
A flac/include/FLAC/stream_decoder.h View 1 1 chunk +1559 lines, -0 lines 0 comments Download
A flac/include/FLAC/stream_encoder.h View 1 1 chunk +1768 lines, -0 lines 0 comments Download
A flac/include/share/alloc.h View 1 1 chunk +20 lines, -0 lines 0 comments Download
A flac/src/libFLAC/alloc.c View 1 1 chunk +59 lines, -0 lines 0 comments Download
A flac/src/libFLAC/bitmath.c View 1 1 chunk +149 lines, -0 lines 0 comments Download
A flac/src/libFLAC/bitreader.c View 1 1 chunk +1376 lines, -0 lines 0 comments Download
A flac/src/libFLAC/bitwriter.c View 1 1 chunk +889 lines, -0 lines 0 comments Download
A flac/src/libFLAC/cpu.c View 1 1 chunk +418 lines, -0 lines 0 comments Download
A flac/src/libFLAC/crc.c View 1 1 chunk +142 lines, -0 lines 0 comments Download
A flac/src/libFLAC/fixed.c View 1 1 chunk +435 lines, -0 lines 0 comments Download
A flac/src/libFLAC/float.c View 1 1 chunk +308 lines, -0 lines 0 comments Download
A flac/src/libFLAC/format.c View 1 1 chunk +593 lines, -0 lines 0 comments Download
A flac/src/libFLAC/include/private/all.h View 1 1 chunk +49 lines, -0 lines 0 comments Download
A flac/src/libFLAC/include/private/bitmath.h View 1 1 chunk +42 lines, -0 lines 0 comments Download
A flac/src/libFLAC/include/private/bitreader.h View 1 1 chunk +99 lines, -0 lines 0 comments Download
A flac/src/libFLAC/include/private/bitwriter.h View 1 1 chunk +103 lines, -0 lines 0 comments Download
A flac/src/libFLAC/include/private/cpu.h View 1 1 chunk +88 lines, -0 lines 0 comments Download
A flac/src/libFLAC/include/private/crc.h View 1 1 chunk +61 lines, -0 lines 0 comments Download
A flac/src/libFLAC/include/private/fixed.h View 1 1 chunk +97 lines, -0 lines 0 comments Download
A flac/src/libFLAC/include/private/float.h View 1 1 chunk +97 lines, -0 lines 0 comments Download
A flac/src/libFLAC/include/private/format.h View 1 1 chunk +44 lines, -0 lines 0 comments Download
A flac/src/libFLAC/include/private/lpc.h View 1 1 chunk +214 lines, -0 lines 0 comments Download
A flac/src/libFLAC/include/private/md5.h View 1 1 chunk +44 lines, -0 lines 0 comments Download
A flac/src/libFLAC/include/private/memory.h View 1 1 chunk +56 lines, -0 lines 0 comments Download
A flac/src/libFLAC/include/private/metadata.h View 1 1 chunk +45 lines, -0 lines 0 comments Download
A flac/src/libFLAC/include/private/stream_encoder_framing.h View 1 1 chunk +45 lines, -0 lines 0 comments Download
A flac/src/libFLAC/include/private/window.h View 1 1 chunk +71 lines, -0 lines 0 comments Download
A flac/src/libFLAC/include/protected/all.h View 1 1 chunk +38 lines, -0 lines 0 comments Download
A flac/src/libFLAC/include/protected/stream_decoder.h View 1 1 chunk +58 lines, -0 lines 0 comments Download
A flac/src/libFLAC/include/protected/stream_encoder.h View 1 1 chunk +110 lines, -0 lines 0 comments Download
A flac/src/libFLAC/lpc.c View 1 1 chunk +1377 lines, -0 lines 0 comments Download
A flac/src/libFLAC/md5.c View 1 1 chunk +424 lines, -0 lines 0 comments Download
A flac/src/libFLAC/memory.c View 1 1 chunk +221 lines, -0 lines 0 comments Download
A flac/src/libFLAC/stream_decoder.c View 1 1 chunk +3387 lines, -0 lines 0 comments Download
A flac/src/libFLAC/stream_encoder.c View 1 1 chunk +4359 lines, -0 lines 0 comments Download
A flac/src/libFLAC/stream_encoder_framing.c View 1 1 chunk +553 lines, -0 lines 0 comments Download
A flac/src/libFLAC/window.c View 1 1 chunk +225 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Satish
9 years, 11 months ago (2011-01-11 15:27:27 UTC) #1
M-A Ruel
lgtm
9 years, 11 months ago (2011-01-11 18:03:51 UTC) #2
Peter Kasting
Just a drive-by question: why FLAC? Wouldn't something lossy (and custom-tuned for voice) like speex ...
9 years, 11 months ago (2011-01-11 18:45:26 UTC) #3
Satish
On 2011/01/11 18:45:26, Peter Kasting wrote: > Just a drive-by question: why FLAC? Wouldn't something ...
9 years, 11 months ago (2011-01-11 20:56:12 UTC) #4
M-A Ruel
On 2011/01/11 20:56:12, Satish wrote: > On 2011/01/11 18:45:26, Peter Kasting wrote: > > Just ...
9 years, 11 months ago (2011-01-11 20:59:08 UTC) #5
Peter Kasting
9 years, 11 months ago (2011-01-11 21:01:49 UTC) #6
I'm OK with pretty much anything for experiments, but make sure you take a hard
look at quality-versus-codesize once you have your data.  I would be sad to ship
FLAC just for high-bandwidth voice recognition.  I suspect that environmental
noise would dominate speex compression losses anyway, but obviously that's what
you want data on :)

Powered by Google App Engine
This is Rietveld 408576698