Issue 611983004: Remove unused parameter in LoginWebDialog constructor

Issue 611983004: Remove unused parameter in LoginWebDialog constructor (Closed)

Created:
6 years, 2 months ago by pkotwicz

Modified:
6 years, 2 months ago

Reviewers:
Nikita (slow)

CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Remove unused parameter in LoginWebDialog constructor BUG=None TEST=None Committed: https://crrev.com/8715901e22db7785f492ff77732662b751da416b Cr-Commit-Position: refs/heads/master@{#297837}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -14 lines)			Patch
M	chrome/browser/chromeos/app_mode/certificate_manager_dialog.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/chromeos/login/help_app_launcher.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/chromeos/login/ui/login_web_dialog.h	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	chrome/browser/chromeos/login/ui/login_web_dialog.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/chromeos/login/ui/proxy_settings_dialog.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 8 (2 generated)

Nikita (slow)

On 2014/10/01 15:24:25, pkotwicz wrote: > nkostylev@ Ping? lgtm, sorry was ooo for two days.

6 years, 2 months ago (2014-10-02 10:03:16 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611983004/1

6 years, 2 months ago (2014-10-02 15:00:37 UTC) #6

commit-bot: I haz the power

Committed patchset #1 (id:1) as b8cbbe51308334162c4307a7565546990fc0191f

6 years, 2 months ago (2014-10-02 15:30:07 UTC) #7

commit-bot: I haz the power

6 years, 2 months ago (2014-10-02 15:30:42 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/8715901e22db7785f492ff77732662b751da416b
Cr-Commit-Position: refs/heads/master@{#297837}