chrome/browser/chromeos/login/help_app_launcher.cc - Issue 611983004: Remove unused parameter in LoginWebDialog constructor

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/chromeos/login/help_app_launcher.cc

Issue 611983004: Remove unused parameter in LoginWebDialog constructor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/chromeos/login/help_app_launcher.h"	5 #include "chrome/browser/chromeos/login/help_app_launcher.h"

6	6

7 #include <string>	7 #include <string>

8	8

9 #include "base/strings/stringprintf.h"	9 #include "base/strings/stringprintf.h"

10 #include "base/strings/utf_string_conversions.h"	10 #include "base/strings/utf_string_conversions.h"

(...skipping 52 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
63 // HelpApp, private:	63 // HelpApp, private:

64	64

65 void HelpAppLauncher::ShowHelpTopicDialog(Profile* profile,	65 void HelpAppLauncher::ShowHelpTopicDialog(Profile* profile,

66 const GURL& topic_url) {	66 const GURL& topic_url) {

67 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));	67 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

68 LoginWebDialog* dialog = new LoginWebDialog(	68 LoginWebDialog* dialog = new LoginWebDialog(

69 profile,	69 profile,

70 NULL,	70 NULL,

71 parent_window_,	71 parent_window_,

72 l10n_util::GetStringUTF16(IDS_LOGIN_OOBE_HELP_DIALOG_TITLE),	72 l10n_util::GetStringUTF16(IDS_LOGIN_OOBE_HELP_DIALOG_TITLE),

73 topic_url,	73 topic_url);

74 LoginWebDialog::STYLE_BUBBLE);

75 gfx::Rect screen_bounds(chromeos::CalculateScreenBounds(gfx::Size()));	74 gfx::Rect screen_bounds(chromeos::CalculateScreenBounds(gfx::Size()));

76 dialog->SetDialogSize(l10n_util::GetLocalizedContentsWidthInPixels(	75 dialog->SetDialogSize(l10n_util::GetLocalizedContentsWidthInPixels(

77 IDS_HELP_APP_DIALOG_WIDTH_PIXELS),	76 IDS_HELP_APP_DIALOG_WIDTH_PIXELS),

78 l10n_util::GetLocalizedContentsWidthInPixels(	77 l10n_util::GetLocalizedContentsWidthInPixels(

79 IDS_HELP_APP_DIALOG_HEIGHT_PIXELS));	78 IDS_HELP_APP_DIALOG_HEIGHT_PIXELS));

80 dialog->Show();	79 dialog->Show();

81 // The dialog object will be deleted on dialog close.	80 // The dialog object will be deleted on dialog close.

82 }	81 }

83	82

84 } // namespace chromeos	83 } // namespace chromeos

OLD	NEW