Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Side by Side Diff: chrome/browser/chromeos/login/ui/login_web_dialog.cc

Issue 611983004: Remove unused parameter in LoginWebDialog constructor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/login/ui/login_web_dialog.h" 5 #include "chrome/browser/chromeos/login/ui/login_web_dialog.h"
6 6
7 #include <deque> 7 #include <deque>
8 8
9 #include "base/lazy_instance.h" 9 #include "base/lazy_instance.h"
10 #include "base/strings/utf_string_conversions.h" 10 #include "base/strings/utf_string_conversions.h"
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 /////////////////////////////////////////////////////////////////////////////// 42 ///////////////////////////////////////////////////////////////////////////////
43 // LoginWebDialog, public: 43 // LoginWebDialog, public:
44 44
45 void LoginWebDialog::Delegate::OnDialogClosed() { 45 void LoginWebDialog::Delegate::OnDialogClosed() {
46 } 46 }
47 47
48 LoginWebDialog::LoginWebDialog(content::BrowserContext* browser_context, 48 LoginWebDialog::LoginWebDialog(content::BrowserContext* browser_context,
49 Delegate* delegate, 49 Delegate* delegate,
50 gfx::NativeWindow parent_window, 50 gfx::NativeWindow parent_window,
51 const base::string16& title, 51 const base::string16& title,
52 const GURL& url, 52 const GURL& url)
53 Style style)
54 : browser_context_(browser_context), 53 : browser_context_(browser_context),
55 parent_window_(parent_window), 54 parent_window_(parent_window),
56 delegate_(delegate), 55 delegate_(delegate),
57 title_(title), 56 title_(title),
58 url_(url), 57 url_(url),
59 style_(style),
60 is_open_(false) { 58 is_open_(false) {
61 gfx::Rect screen_bounds(chromeos::CalculateScreenBounds(gfx::Size())); 59 gfx::Rect screen_bounds(chromeos::CalculateScreenBounds(gfx::Size()));
62 width_ = static_cast<int>(kDefaultWidthRatio * screen_bounds.width()); 60 width_ = static_cast<int>(kDefaultWidthRatio * screen_bounds.width());
63 height_ = static_cast<int>(kDefaultHeightRatio * screen_bounds.height()); 61 height_ = static_cast<int>(kDefaultHeightRatio * screen_bounds.height());
64 } 62 }
65 63
66 LoginWebDialog::~LoginWebDialog() { 64 LoginWebDialog::~LoginWebDialog() {
67 delegate_ = NULL; 65 delegate_ = NULL;
68 } 66 }
69 67
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
161 159
162 void LoginWebDialog::Observe(int type, 160 void LoginWebDialog::Observe(int type,
163 const content::NotificationSource& source, 161 const content::NotificationSource& source,
164 const content::NotificationDetails& details) { 162 const content::NotificationDetails& details) {
165 DCHECK(type == content::NOTIFICATION_LOAD_COMPLETED_MAIN_FRAME); 163 DCHECK(type == content::NOTIFICATION_LOAD_COMPLETED_MAIN_FRAME);
166 // TODO(saintlou): Do we need a throbber for Aura? 164 // TODO(saintlou): Do we need a throbber for Aura?
167 NOTIMPLEMENTED(); 165 NOTIMPLEMENTED();
168 } 166 }
169 167
170 } // namespace chromeos 168 } // namespace chromeos
OLDNEW
« no previous file with comments | « chrome/browser/chromeos/login/ui/login_web_dialog.h ('k') | chrome/browser/chromeos/login/ui/proxy_settings_dialog.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698