Replace OVERRIDE with its C++11 counterpart in components/password_manager/

Replace OVERRIDE with its C++11 counterpart in components/password_manager/

This CL replaces |OVERRIDE| with |override| as per allowed C++11 features.
|FINAL| is already not used in components/password_manager/

BUG=417463
Committed: https://crrev.com/ebd89062890217392ba453bea3629d0e1e19eaea
Cr-Commit-Position: refs/heads/master@{#297600}

[Sunil Ratnu, 2014-09-30 13:36:16]

sunil.ratnu@samsung.com changed reviewers:
+ vabr@chromium.org

[Sunil Ratnu, 2014-09-30 13:36:17]

Hi Vaclav,

Please review this!

Thanks!
Sunil

[vabr (Chromium), 2014-09-30 14:39:14]

LGTM with a comment.
Thanks!
Vaclav

https://codereview.chromium.org/611383002/diff/1/components/password_manager/...
File components/password_manager/content/renderer/credential_manager_client.h
(right):

https://codereview.chromium.org/611383002/diff/1/components/password_manager/...
components/password_manager/content/renderer/credential_manager_client.h:66:
WebCredentialManagerClient::NotificationCallbacks* callbacks) override;
Actually, methods from Blink should have no override directives, until Blink is
part of Chromium directly (rather than through third_party inclusion). See
https://codereview.chromium.org/613993002/#msg4

[Sunil Ratnu, 2014-09-30 15:06:18]

Patchset #2 (id:20001) has been deleted

[Sunil Ratnu, 2014-09-30 15:10:51]

https://codereview.chromium.org/611383002/diff/1/components/password_manager/...
File components/password_manager/content/renderer/credential_manager_client.h
(right):

https://codereview.chromium.org/611383002/diff/1/components/password_manager/...
components/password_manager/content/renderer/credential_manager_client.h:66:
WebCredentialManagerClient::NotificationCallbacks* callbacks) override;
On 2014/09/30 14:39:14, vabr (Chromium) wrote:
> Actually, methods from Blink should have no override directives, until Blink
is
> part of Chromium directly (rather than through third_party inclusion). See
> https://codereview.chromium.org/613993002/#msg4

Oh! I did not know that. Made the changes as per your comments.

[Sunil Ratnu, 2014-09-30 15:11:36]

The CQ bit was checked by sunil.ratnu@samsung.com

[commit-bot: I haz the power, 2014-09-30 15:12:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/611383002/40001

[commit-bot: I haz the power, 2014-09-30 15:15:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-30 15:15:46]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/62503)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  linux_chromium_gn_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)

[Sunil Ratnu, 2014-09-30 16:15:56]

Patch Failure Error. Will rebase and upload a new patchset tomorrow.

[Sunil Ratnu, 2014-10-01 05:57:12]

The CQ bit was checked by sunil.ratnu@samsung.com

[commit-bot: I haz the power, 2014-10-01 05:57:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/611383002/60001

[commit-bot: I haz the power, 2014-10-01 06:38:53]

Committed patchset #3 (id:60001) as 182ce514d98aeb010da288c6cf6bf56b9b460cac

[commit-bot: I haz the power, 2014-10-01 06:39:30]

Patchset 3 (id:??) landed as
https://crrev.com/ebd89062890217392ba453bea3629d0e1e19eaea
Cr-Commit-Position: refs/heads/master@{#297600}

[tapted, 2014-10-01 07:58:10]

On 2014/10/01 06:39:30, I haz the power (commit-bot) wrote:
> Patchset 3 (id:??) landed as
> https://crrev.com/ebd89062890217392ba453bea3629d0e1e19eaea
> Cr-Commit-Position: refs/heads/master@{#297600}

revert button not working, so will try manually.

I suspect this has collided with  https://codereview.chromium.org/613143003/ or
its revert
and is causing some persistent compile failures on the Webkit GPU Mac Builder

link:
http://build.chromium.org/p/chromium.webkit/builders/GPU%20Mac%20Builder/buil...

errors like: FAILED: /Volumes/data/b/build/goma/gomacc
../../third_party/llvm-build/Release+Asserts/bin/clang++ -shared -framework
Cocoa -framework Foundation -framework IOKit -framework Security -framework
SystemConfiguration -framework Carbon -Wl,-search_paths_first -Wl,-ObjC
-Wl,-dead_strip -compatibility_version 2175.0.0 -current_version 2175.0.0
-mmacosx-version-min=10.6 -isysroot
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk
-Wl,-order_file -Wl,../../chrome/app/framework.order -arch i386 -L.
-install_name @executable_path/../Versions/40.0.2175.0/Chromium\
Framework.framework/Chromium\ Framework -o "Chromium
Framework.framework/Versions/A/Chromium Framework"
@Chromium_Framework.framework.rsp
Undefined symbols for architecture i386:
  "__ZN16password_manager14CredentialInfoC1ERKN8autofill12PasswordFormE",
referenced from:
     
__ZN16password_manager34ContentCredentialManagerDispatcher25OnGetPasswordStoreResultsERKSt6vectorIPN8autofill12PasswordFormESaIS4_EE
in
libpassword_manager_content_browser.a(password_manager_content_browser.content_credential_manager_dispatcher.o)

[Sunil Ratnu, 2014-10-01 09:05:05]

Just FTR, this was not reverted as seen can be seen at
https://codereview.chromium.org/616283002/