Replace OVERRIDE with its C++11 counterpart in components/password_manager/

components/password_manager/content/renderer/credential_manager_client.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_PASSWORD_MANAGER_CONTENT_RENDERER_CREDENTIAL_MANAGER_CLIENT_H_
 #define COMPONENTS_PASSWORD_MANAGER_CONTENT_RENDERER_CREDENTIAL_MANAGER_CLIENT_H_
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/id_map.h"
@@ skipping 33 matching lines @@
 // Note that each RenderView's WebView holds a pointer to the
 // CredentialManagerClient (set in 'OnRenderViewCreated()'). The client is
 // guaranteed to outlive the views that point to it.
 class CredentialManagerClient : public blink::WebCredentialManagerClient,
                                 public content::RenderViewObserver {
  public:
   explicit CredentialManagerClient(content::RenderView* render_view);
   virtual ~CredentialManagerClient();
 
   // RenderViewObserver:
-  virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
+  virtual bool OnMessageReceived(const IPC::Message& message) override;
 
   // Message handlers for messages from the browser process:
   virtual void OnAcknowledgeFailedSignIn(int request_id);
   virtual void OnAcknowledgeSignedIn(int request_id);
   virtual void OnAcknowledgeSignedOut(int request_id);
   virtual void OnSendCredential(int request_id,
                                 const CredentialInfo& credential_info);
 
   // blink::WebCredentialManager:
   virtual void dispatchFailedSignIn(
       const blink::WebCredential& credential,
-      WebCredentialManagerClient::NotificationCallbacks* callbacks) OVERRIDE;
+      WebCredentialManagerClient::NotificationCallbacks* callbacks) override;

[vabr (Chromium), 2014/09/30 14:39:14]

Actually, methods from Blink should have no override directives, until Blink is
part of Chromium directly (rather than through third_party inclusion). See
https://codereview.chromium.org/613993002/#msg4

[Sunil Ratnu, 2014/09/30 15:10:51]

Oh! I did not know that. Made the changes as per your comments.

   virtual void dispatchSignedIn(
       const blink::WebCredential& credential,
-      WebCredentialManagerClient::NotificationCallbacks* callbacks) OVERRIDE;
-  virtual void dispatchSignedOut(NotificationCallbacks* callbacks) OVERRIDE;
+      WebCredentialManagerClient::NotificationCallbacks* callbacks) override;
+  virtual void dispatchSignedOut(NotificationCallbacks* callbacks) override;
   virtual void dispatchRequest(
       bool zero_click_only,
       const blink::WebVector<blink::WebURL>& federations,
-      RequestCallbacks* callbacks) OVERRIDE;
+      RequestCallbacks* callbacks) override;
 
  private:
   typedef IDMap<blink::WebCredentialManagerClient::RequestCallbacks,
                 IDMapOwnPointer> RequestCallbacksMap;
   typedef IDMap<blink::WebCredentialManagerClient::NotificationCallbacks,
                 IDMapOwnPointer> NotificationCallbacksMap;
 
   void RespondToNotificationCallback(int request_id,
                                      NotificationCallbacksMap* map);
 
   // Track the various blink::WebCredentialManagerClient::*Callbacks objects
   // generated from Blink. This class takes ownership of these objects.
   NotificationCallbacksMap failed_sign_in_callbacks_;
   NotificationCallbacksMap signed_in_callbacks_;
   NotificationCallbacksMap signed_out_callbacks_;
   RequestCallbacksMap request_callbacks_;
 
   DISALLOW_COPY_AND_ASSIGN(CredentialManagerClient);
 };
 
 }  // namespace password_manager
 
 #endif  // COMPONENTS_PASSWORD_MANAGER_CONTENT_RENDERER_CREDENTIAL_MANAGER_CLIENT_H_