Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 610643003: Adds new webview.loadDataWithBaseUrl API to allow data URLs to be loaded with a specified base URL … (Closed)

Created:
6 years, 2 months ago by paulmeyer
Modified:
6 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, asvitkine+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Adds new webview.loadDataWithBaseUrl API to allow data URLs to be loaded with a specified base URL as well as an optionally specified virtual URL via NavigationController::LoadURLWithParams. The signature is loadDataWithBaseUrl(dataUrl, baseUrl [, virtualUrl]). BUG=399790 Committed: https://crrev.com/779d2725172a955bce3beae188e1cccf0e656a93 Cr-Commit-Position: refs/heads/master@{#297258}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed comments. #

Total comments: 2

Patch Set 3 : Addressed comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+232 lines, -4 lines) Patch
M chrome/browser/apps/web_view_browsertest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/webview_tag.json View 3 chunks +25 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/web_view/shim/main.js View 3 chunks +42 lines, -1 line 0 comments Download
A chrome/test/data/extensions/platform_apps/web_view/shim/test.bmp View Binary file 0 comments Download
M extensions/browser/api/web_view/web_view_internal_api.h View 1 chunk +17 lines, -0 lines 0 comments Download
M extensions/browser/api/web_view/web_view_internal_api.cc View 1 2 chunks +26 lines, -0 lines 0 comments Download
M extensions/browser/extension_function_histogram_value.h View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_constants.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_constants.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest.cc View 1 2 1 chunk +43 lines, -0 lines 0 comments Download
M extensions/common/api/web_view_internal.json View 2 chunks +35 lines, -1 line 0 comments Download
M extensions/renderer/resources/web_view_experimental.js View 2 chunks +22 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (5 generated)
paulmeyer
+fsamuel@
6 years, 2 months ago (2014-09-26 17:36:42 UTC) #4
Fady Samuel
https://codereview.chromium.org/610643003/diff/40001/extensions/browser/api/web_view/web_view_internal_api.cc File extensions/browser/api/web_view/web_view_internal_api.cc (right): https://codereview.chromium.org/610643003/diff/40001/extensions/browser/api/web_view/web_view_internal_api.cc#newcode315 extensions/browser/api/web_view/web_view_internal_api.cc:315: EXTENSION_FUNCTION_VALIDATE(params.get()); Could you please move the code below to ...
6 years, 2 months ago (2014-09-26 18:06:39 UTC) #5
paulmeyer
ptal https://codereview.chromium.org/610643003/diff/40001/extensions/browser/api/web_view/web_view_internal_api.cc File extensions/browser/api/web_view/web_view_internal_api.cc (right): https://codereview.chromium.org/610643003/diff/40001/extensions/browser/api/web_view/web_view_internal_api.cc#newcode315 extensions/browser/api/web_view/web_view_internal_api.cc:315: EXTENSION_FUNCTION_VALIDATE(params.get()); On 2014/09/26 18:06:39, Fady Samuel wrote: > ...
6 years, 2 months ago (2014-09-26 19:44:29 UTC) #6
Fady Samuel
https://codereview.chromium.org/610643003/diff/60001/extensions/browser/guest_view/web_view/web_view_guest.cc File extensions/browser/guest_view/web_view/web_view_guest.cc (right): https://codereview.chromium.org/610643003/diff/60001/extensions/browser/guest_view/web_view/web_view_guest.cc#newcode1041 extensions/browser/guest_view/web_view/web_view_guest.cc:1041: web_contents()->Focus(); Let's avoid this? Focus should be managed separately.
6 years, 2 months ago (2014-09-29 14:59:00 UTC) #7
paulmeyer
ptal https://codereview.chromium.org/610643003/diff/60001/extensions/browser/guest_view/web_view/web_view_guest.cc File extensions/browser/guest_view/web_view/web_view_guest.cc (right): https://codereview.chromium.org/610643003/diff/60001/extensions/browser/guest_view/web_view/web_view_guest.cc#newcode1041 extensions/browser/guest_view/web_view/web_view_guest.cc:1041: web_contents()->Focus(); On 2014/09/29 14:59:00, Fady Samuel wrote: > ...
6 years, 2 months ago (2014-09-29 15:19:04 UTC) #8
Fady Samuel
lgtm
6 years, 2 months ago (2014-09-29 17:27:43 UTC) #9
paulmeyer
+asvitkine@ for ownership review of extension_function_histogram_value.h and histograms.xml +rockot@ for ownership review of extensions/browser/api/
6 years, 2 months ago (2014-09-29 18:08:26 UTC) #11
Alexei Svitkine (slow)
lgtm
6 years, 2 months ago (2014-09-29 18:11:26 UTC) #12
Ken Rockot(use gerrit already)
c/b/e/api lgtm
6 years, 2 months ago (2014-09-29 19:58:46 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/610643003/80001
6 years, 2 months ago (2014-09-29 20:00:15 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:80001) as 193f1e1b2b3a073f5adfabc3fa2b6b121bc3b1e7
6 years, 2 months ago (2014-09-29 21:06:43 UTC) #16
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 21:09:26 UTC) #17
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/779d2725172a955bce3beae188e1cccf0e656a93
Cr-Commit-Position: refs/heads/master@{#297258}

Powered by Google App Engine
This is Rietveld 408576698