extensions/browser/guest_view/web_view/web_view_constants.cc - Issue 610643003: Adds new webview.loadDataWithBaseUrl API to allow data URLs to be loaded with a specified base URL …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/web_view/web_view_constants.cc

Issue 610643003: Adds new webview.loadDataWithBaseUrl API to allow data URLs to be loaded with a specified base URL … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comment. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/guest_view/web_view/web_view_constants.h ('k') | extensions/browser/guest_view/web_view/web_view_guest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/web_view/web_view_constants.cc

diff --git a/extensions/browser/guest_view/web_view/web_view_constants.cc b/extensions/browser/guest_view/web_view/web_view_constants.cc

index 83e428f4b00561de1dd95ac8ec791862e0f6067a..9454292e106a571aec9846974222677d32b81a60 100644

--- a/extensions/browser/guest_view/web_view/web_view_constants.cc

+++ b/extensions/browser/guest_view/web_view/web_view_constants.cc

@@ -19,6 +19,11 @@ const char kAttributeSrc[] = "src";

// API namespace.

const char kAPINamespace[] = "webViewInternal";

+// API error messages.

+const char kAPILoadDataInvalidDataURL[] = "Invalid data URL \"%s\".";

+const char kAPILoadDataInvalidBaseURL[] = "Invalid base URL \"%s\".";

+const char kAPILoadDataInvalidVirtualURL[] = "Invalid virtual URL \"%s\".";

// Events.

const char kEventClose[] = "webViewInternal.onClose";

const char kEventConsoleMessage[] = "webViewInternal.onConsoleMessage";