extensions/browser/guest_view/web_view/web_view_constants.h - Issue 610643003: Adds new webview.loadDataWithBaseUrl API to allow data URLs to be loaded with a specified base URL …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/web_view/web_view_constants.h

Issue 610643003: Adds new webview.loadDataWithBaseUrl API to allow data URLs to be loaded with a specified base URL … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comment. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/extension_function_histogram_value.h ('k') | extensions/browser/guest_view/web_view/web_view_constants.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/web_view/web_view_constants.h

diff --git a/extensions/browser/guest_view/web_view/web_view_constants.h b/extensions/browser/guest_view/web_view/web_view_constants.h

index 1278394dd63c51f267b4fad96d4c6d43d8738530..c7ee2063020341f5764b3883cb6ff56d3c9056c4 100644

--- a/extensions/browser/guest_view/web_view/web_view_constants.h

+++ b/extensions/browser/guest_view/web_view/web_view_constants.h

@@ -23,6 +23,11 @@ extern const char kAttributeSrc[];

// TODO(kalman): Consolidate this with the other API constants.

extern const char kAPINamespace[];

+// API error messages.

+extern const char kAPILoadDataInvalidDataURL[];

+extern const char kAPILoadDataInvalidBaseURL[];

+extern const char kAPILoadDataInvalidVirtualURL[];

// Events.

extern const char kEventClose[];

extern const char kEventConsoleMessage[];