Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1182)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 610223002: [SyncFS] Use nullptr instead of NULL (Closed)

Created:
6 years, 2 months ago by tzik
Modified:
6 years, 2 months ago
Reviewers:
peria
CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[SyncFS] Use nullptr instead of NULL * s/NULL/nullptr/g * Fix lint errors BUG=None Committed: https://crrev.com/b27b14b0a3e8ffe89cd63d4bdde6578fcbe5cfa0 Cr-Commit-Position: refs/heads/master@{#297132}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -141 lines) Patch
M chrome/browser/sync_file_system/drive_backend/conflict_resolver_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc View 5 chunks +14 lines, -13 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/folder_creator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/leveldb_wrapper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/list_changes_task_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_index.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc View 5 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk_unittest.cc View 16 chunks +29 lines, -26 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_index_unittest.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_db_migration_util_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/register_app_task.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/register_app_task_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_initializer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc View 2 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_task_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_worker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/task_dependency_manager_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/file_change.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/local/canned_syncable_file_system.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/sync_file_system/local/local_file_change_tracker.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/local/local_file_change_tracker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/local/local_file_sync_context_unittest.cc View 15 chunks +16 lines, -16 lines 0 comments Download
M chrome/browser/sync_file_system/local/local_file_sync_service.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/local/sync_file_system_backend.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/sync_file_system/local/syncable_file_operation_runner_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/local/syncable_file_system_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/sync_file_system_service.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync_file_system/sync_process_runner_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
tzik
PTL
6 years, 2 months ago (2014-09-29 02:01:57 UTC) #2
peria
lgtm
6 years, 2 months ago (2014-09-29 02:28:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/610223002/1
6 years, 2 months ago (2014-09-29 02:30:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 423904f681c61ffdf0ec9dcb17e01d4186cf9df8
6 years, 2 months ago (2014-09-29 03:11:35 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 03:12:27 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b27b14b0a3e8ffe89cd63d4bdde6578fcbe5cfa0
Cr-Commit-Position: refs/heads/master@{#297132}

Powered by Google App Engine
This is Rietveld 408576698