Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Side by Side Diff: chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc

Issue 610223002: [SyncFS] Use nullptr instead of NULL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/sync_file_system/drive_backend/metadata_database.h" 5 #include "chrome/browser/sync_file_system/drive_backend/metadata_database.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/files/scoped_temp_dir.h" 8 #include "base/files/scoped_temp_dir.h"
9 #include "base/message_loop/message_loop.h" 9 #include "base/message_loop/message_loop.h"
10 #include "base/strings/string_number_conversions.h" 10 #include "base/strings/string_number_conversions.h"
(...skipping 214 matching lines...) Expand 10 before | Expand all | Expand 10 after
225 if (!file->tracker_only) 225 if (!file->tracker_only)
226 EXPECT_TRUE(PutFileToDB(db.get(), file->metadata).ok()); 226 EXPECT_TRUE(PutFileToDB(db.get(), file->metadata).ok());
227 EXPECT_TRUE(PutTrackerToDB(db.get(), file->tracker).ok()); 227 EXPECT_TRUE(PutTrackerToDB(db.get(), file->tracker).ok());
228 } 228 }
229 } 229 }
230 230
231 void VerifyTrackedFile(const TrackedFile& file) { 231 void VerifyTrackedFile(const TrackedFile& file) {
232 if (!file.should_be_absent) { 232 if (!file.should_be_absent) {
233 if (file.tracker_only) { 233 if (file.tracker_only) {
234 EXPECT_FALSE(metadata_database()->FindFileByFileID( 234 EXPECT_FALSE(metadata_database()->FindFileByFileID(
235 file.metadata.file_id(), NULL)); 235 file.metadata.file_id(), nullptr));
236 } else { 236 } else {
237 VerifyFile(file.metadata); 237 VerifyFile(file.metadata);
238 } 238 }
239 VerifyTracker(file.tracker); 239 VerifyTracker(file.tracker);
240 return; 240 return;
241 } 241 }
242 242
243 EXPECT_FALSE(metadata_database()->FindFileByFileID( 243 EXPECT_FALSE(metadata_database()->FindFileByFileID(
244 file.metadata.file_id(), NULL)); 244 file.metadata.file_id(), nullptr));
245 EXPECT_FALSE(metadata_database()->FindTrackerByTrackerID( 245 EXPECT_FALSE(metadata_database()->FindTrackerByTrackerID(
246 file.tracker.tracker_id(), NULL)); 246 file.tracker.tracker_id(), nullptr));
247 } 247 }
248 248
249 void VerifyTrackedFiles(const TrackedFile** tracked_files, int size) { 249 void VerifyTrackedFiles(const TrackedFile** tracked_files, int size) {
250 for (int i = 0; i < size; ++i) 250 for (int i = 0; i < size; ++i)
251 VerifyTrackedFile(*tracked_files[i]); 251 VerifyTrackedFile(*tracked_files[i]);
252 } 252 }
253 253
254 MetadataDatabase* metadata_database() { return metadata_database_.get(); } 254 MetadataDatabase* metadata_database() { return metadata_database_.get(); }
255 255
256 scoped_ptr<LevelDBWrapper> InitializeLevelDB() { 256 scoped_ptr<LevelDBWrapper> InitializeLevelDB() {
257 leveldb::DB* db = NULL; 257 leveldb::DB* db = nullptr;
258 leveldb::Options options; 258 leveldb::Options options;
259 options.create_if_missing = true; 259 options.create_if_missing = true;
260 options.max_open_files = 0; // Use minimum. 260 options.max_open_files = 0; // Use minimum.
261 options.env = in_memory_env_.get(); 261 options.env = in_memory_env_.get();
262 leveldb::Status status = 262 leveldb::Status status =
263 leveldb::DB::Open(options, database_dir_.path().AsUTF8Unsafe(), &db); 263 leveldb::DB::Open(options, database_dir_.path().AsUTF8Unsafe(), &db);
264 EXPECT_TRUE(status.ok()); 264 EXPECT_TRUE(status.ok());
265 265
266 scoped_ptr<LevelDBWrapper> wrapper(new LevelDBWrapper(make_scoped_ptr(db))); 266 scoped_ptr<LevelDBWrapper> wrapper(new LevelDBWrapper(make_scoped_ptr(db)));
267 267
(...skipping 866 matching lines...) Expand 10 before | Expand all | Expand 10 after
1134 }; 1134 };
1135 1135
1136 SetUpDatabaseByTrackedFiles(tracked_files, arraysize(tracked_files)); 1136 SetUpDatabaseByTrackedFiles(tracked_files, arraysize(tracked_files));
1137 EXPECT_EQ(SYNC_STATUS_OK, InitializeMetadataDatabase()); 1137 EXPECT_EQ(SYNC_STATUS_OK, InitializeMetadataDatabase());
1138 VerifyTrackedFiles(tracked_files, arraysize(tracked_files)); 1138 VerifyTrackedFiles(tracked_files, arraysize(tracked_files));
1139 1139
1140 scoped_ptr<base::ListValue> files = 1140 scoped_ptr<base::ListValue> files =
1141 metadata_database()->DumpFiles(app_root.tracker.app_id()); 1141 metadata_database()->DumpFiles(app_root.tracker.app_id());
1142 ASSERT_EQ(2u, files->GetSize()); 1142 ASSERT_EQ(2u, files->GetSize());
1143 1143
1144 base::DictionaryValue* file = NULL; 1144 base::DictionaryValue* file = nullptr;
1145 std::string str; 1145 std::string str;
1146 1146
1147 ASSERT_TRUE(files->GetDictionary(0, &file)); 1147 ASSERT_TRUE(files->GetDictionary(0, &file));
1148 EXPECT_TRUE(file->GetString("title", &str) && str == "folder_0"); 1148 EXPECT_TRUE(file->GetString("title", &str) && str == "folder_0");
1149 EXPECT_TRUE(file->GetString("type", &str) && str == "folder"); 1149 EXPECT_TRUE(file->GetString("type", &str) && str == "folder");
1150 EXPECT_TRUE(file->HasKey("details")); 1150 EXPECT_TRUE(file->HasKey("details"));
1151 1151
1152 ASSERT_TRUE(files->GetDictionary(1, &file)); 1152 ASSERT_TRUE(files->GetDictionary(1, &file));
1153 EXPECT_TRUE(file->GetString("title", &str) && str == "file_0"); 1153 EXPECT_TRUE(file->GetString("title", &str) && str == "file_0");
1154 EXPECT_TRUE(file->GetString("type", &str) && str == "file"); 1154 EXPECT_TRUE(file->GetString("type", &str) && str == "file");
1155 EXPECT_TRUE(file->HasKey("details")); 1155 EXPECT_TRUE(file->HasKey("details"));
1156 } 1156 }
1157 1157
1158 } // namespace drive_backend 1158 } // namespace drive_backend
1159 } // namespace sync_file_system 1159 } // namespace sync_file_system
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698