Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Side by Side Diff: chrome/browser/sync_file_system/drive_backend/metadata_database_index_unittest.cc

Issue 610223002: [SyncFS] Use nullptr instead of NULL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/sync_file_system/drive_backend/metadata_database_index. h" 5 #include "chrome/browser/sync_file_system/drive_backend/metadata_database_index. h"
6 6
7 #include "chrome/browser/sync_file_system/drive_backend/drive_backend_constants. h" 7 #include "chrome/browser/sync_file_system/drive_backend/drive_backend_constants. h"
8 #include "chrome/browser/sync_file_system/drive_backend/drive_backend_test_util. h" 8 #include "chrome/browser/sync_file_system/drive_backend/drive_backend_test_util. h"
9 #include "chrome/browser/sync_file_system/drive_backend/leveldb_wrapper.h" 9 #include "chrome/browser/sync_file_system/drive_backend/leveldb_wrapper.h"
10 #include "chrome/browser/sync_file_system/drive_backend/metadata_database.h" 10 #include "chrome/browser/sync_file_system/drive_backend/metadata_database.h"
(...skipping 13 matching lines...) Expand all
24 const int64 kFileTrackerID = 3; 24 const int64 kFileTrackerID = 3;
25 const int64 kPlaceholderTrackerID = 4; 25 const int64 kPlaceholderTrackerID = 4;
26 26
27 scoped_ptr<DatabaseContents> CreateTestDatabaseContents() { 27 scoped_ptr<DatabaseContents> CreateTestDatabaseContents() {
28 scoped_ptr<DatabaseContents> contents(new DatabaseContents); 28 scoped_ptr<DatabaseContents> contents(new DatabaseContents);
29 29
30 scoped_ptr<FileMetadata> sync_root_metadata = 30 scoped_ptr<FileMetadata> sync_root_metadata =
31 test_util::CreateFolderMetadata("sync_root_folder_id", 31 test_util::CreateFolderMetadata("sync_root_folder_id",
32 "Chrome Syncable FileSystem"); 32 "Chrome Syncable FileSystem");
33 scoped_ptr<FileTracker> sync_root_tracker = 33 scoped_ptr<FileTracker> sync_root_tracker =
34 test_util::CreateTracker(*sync_root_metadata, kSyncRootTrackerID, NULL); 34 test_util::CreateTracker(*sync_root_metadata, kSyncRootTrackerID,
35 nullptr);
35 36
36 scoped_ptr<FileMetadata> app_root_metadata = 37 scoped_ptr<FileMetadata> app_root_metadata =
37 test_util::CreateFolderMetadata("app_root_folder_id", "app_id"); 38 test_util::CreateFolderMetadata("app_root_folder_id", "app_id");
38 scoped_ptr<FileTracker> app_root_tracker = 39 scoped_ptr<FileTracker> app_root_tracker =
39 test_util::CreateTracker(*app_root_metadata, kAppRootTrackerID, 40 test_util::CreateTracker(*app_root_metadata, kAppRootTrackerID,
40 sync_root_tracker.get()); 41 sync_root_tracker.get());
41 app_root_tracker->set_app_id("app_id"); 42 app_root_tracker->set_app_id("app_id");
42 app_root_tracker->set_tracker_kind(TRACKER_KIND_APP_ROOT); 43 app_root_tracker->set_tracker_kind(TRACKER_KIND_APP_ROOT);
43 44
44 scoped_ptr<FileMetadata> file_metadata = 45 scoped_ptr<FileMetadata> file_metadata =
(...skipping 27 matching lines...) Expand all
72 73
73 contents_ = CreateTestDatabaseContents(); 74 contents_ = CreateTestDatabaseContents();
74 index_ = MetadataDatabaseIndex::CreateForTesting(contents_.get(), 75 index_ = MetadataDatabaseIndex::CreateForTesting(contents_.get(),
75 db_.get()); 76 db_.get());
76 } 77 }
77 78
78 MetadataDatabaseIndex* index() { return index_.get(); } 79 MetadataDatabaseIndex* index() { return index_.get(); }
79 80
80 private: 81 private:
81 void InitializeLevelDB() { 82 void InitializeLevelDB() {
82 leveldb::DB* db = NULL; 83 leveldb::DB* db = nullptr;
83 leveldb::Options options; 84 leveldb::Options options;
84 options.create_if_missing = true; 85 options.create_if_missing = true;
85 options.max_open_files = 0; // Use minimum. 86 options.max_open_files = 0; // Use minimum.
86 options.env = in_memory_env_.get(); 87 options.env = in_memory_env_.get();
87 leveldb::Status status = leveldb::DB::Open(options, "", &db); 88 leveldb::Status status = leveldb::DB::Open(options, "", &db);
88 ASSERT_TRUE(status.ok()); 89 ASSERT_TRUE(status.ok());
89 90
90 db_.reset(new LevelDBWrapper(make_scoped_ptr(db))); 91 db_.reset(new LevelDBWrapper(make_scoped_ptr(db)));
91 } 92 }
92 93
93 scoped_ptr<DatabaseContents> contents_; 94 scoped_ptr<DatabaseContents> contents_;
94 scoped_ptr<MetadataDatabaseIndex> index_; 95 scoped_ptr<MetadataDatabaseIndex> index_;
95 96
96 scoped_ptr<leveldb::Env> in_memory_env_; 97 scoped_ptr<leveldb::Env> in_memory_env_;
97 scoped_ptr<LevelDBWrapper> db_; 98 scoped_ptr<LevelDBWrapper> db_;
98 }; 99 };
99 100
100 TEST_F(MetadataDatabaseIndexTest, GetEntryTest) { 101 TEST_F(MetadataDatabaseIndexTest, GetEntryTest) {
101 FileTracker tracker; 102 FileTracker tracker;
102 EXPECT_FALSE(index()->GetFileTracker(kInvalidTrackerID, NULL)); 103 EXPECT_FALSE(index()->GetFileTracker(kInvalidTrackerID, nullptr));
103 ASSERT_TRUE(index()->GetFileTracker(kFileTrackerID, &tracker)); 104 ASSERT_TRUE(index()->GetFileTracker(kFileTrackerID, &tracker));
104 EXPECT_EQ(kFileTrackerID, tracker.tracker_id()); 105 EXPECT_EQ(kFileTrackerID, tracker.tracker_id());
105 EXPECT_EQ("file_id", tracker.file_id()); 106 EXPECT_EQ("file_id", tracker.file_id());
106 107
107 FileMetadata metadata; 108 FileMetadata metadata;
108 EXPECT_FALSE(index()->GetFileMetadata(std::string(), NULL)); 109 EXPECT_FALSE(index()->GetFileMetadata(std::string(), nullptr));
109 ASSERT_TRUE(index()->GetFileMetadata("file_id", &metadata)); 110 ASSERT_TRUE(index()->GetFileMetadata("file_id", &metadata));
110 EXPECT_EQ("file_id", metadata.file_id()); 111 EXPECT_EQ("file_id", metadata.file_id());
111 } 112 }
112 113
113 TEST_F(MetadataDatabaseIndexTest, IndexLookUpTest) { 114 TEST_F(MetadataDatabaseIndexTest, IndexLookUpTest) {
114 TrackerIDSet trackers = index()->GetFileTrackerIDsByFileID("file_id"); 115 TrackerIDSet trackers = index()->GetFileTrackerIDsByFileID("file_id");
115 EXPECT_EQ(1u, trackers.size()); 116 EXPECT_EQ(1u, trackers.size());
116 EXPECT_TRUE(trackers.has_active()); 117 EXPECT_TRUE(trackers.has_active());
117 EXPECT_EQ(kFileTrackerID, trackers.active_tracker()); 118 EXPECT_EQ(kFileTrackerID, trackers.active_tracker());
118 119
(...skipping 29 matching lines...) Expand all
148 new_tracker->set_active(false); 149 new_tracker->set_active(false);
149 index()->StoreFileTracker(new_tracker.Pass()); 150 index()->StoreFileTracker(new_tracker.Pass());
150 151
151 EXPECT_EQ("file_id", index()->PickMultiTrackerFileID()); 152 EXPECT_EQ("file_id", index()->PickMultiTrackerFileID());
152 EXPECT_EQ(ParentIDAndTitle(kAppRootTrackerID, std::string("file")), 153 EXPECT_EQ(ParentIDAndTitle(kAppRootTrackerID, std::string("file")),
153 index()->PickMultiBackingFilePath()); 154 index()->PickMultiBackingFilePath());
154 155
155 index()->RemoveFileMetadata("file_id"); 156 index()->RemoveFileMetadata("file_id");
156 index()->RemoveFileTracker(kFileTrackerID); 157 index()->RemoveFileTracker(kFileTrackerID);
157 158
158 EXPECT_FALSE(index()->GetFileMetadata("file_id", NULL)); 159 EXPECT_FALSE(index()->GetFileMetadata("file_id", nullptr));
159 EXPECT_FALSE(index()->GetFileTracker(kFileTrackerID, NULL)); 160 EXPECT_FALSE(index()->GetFileTracker(kFileTrackerID, nullptr));
160 } 161 }
161 162
162 } // namespace drive_backend 163 } // namespace drive_backend
163 } // namespace sync_file_system 164 } // namespace sync_file_system
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698