Convert GN's deps iterator to work with range-based for loops.

Convert GN's deps iterator to work with range-based for loops.

Reworks DepsIterator so it is compatible with STL iterators enough to work with range-based for loops. The iterator is now created by a target rather than taking a target as an argument, which makes the loops more natural.

I also changed some loops around code I was touching to use range-based.

Committed: https://crrev.com/a09df11aa1c5f416df4fb97f2303d9c1ff76b150
Cr-Commit-Position: refs/heads/master@{#297122}

[brettw, 2014-09-26 23:44:50]

brettw@chromium.org changed reviewers:
+ jam@chromium.org

[brettw, 2014-09-26 23:45:21]

brettw@chromium.org changed reviewers:
+ scottmg@chromium.org
- jam@chromium.org

[brettw, 2014-09-26 23:45:21]

Whoops, meant to send this to Scott.

[tfarina, 2014-09-27 00:33:56]

https://codereview.chromium.org/610043002/diff/40001/tools/gn/command_refs.cc
File tools/gn/command_refs.cc (right):

https://codereview.chromium.org/610043002/diff/40001/tools/gn/command_refs.cc...
tools/gn/command_refs.cc:23: typedef std::vector<const Target*> TargetVector;
you can remove this, it is unused.

[scottmg, 2014-09-27 00:40:07]

lgtm

https://codereview.chromium.org/610043002/diff/40001/tools/gn/target.cc
File tools/gn/target.cc (right):

https://codereview.chromium.org/610043002/diff/40001/tools/gn/target.cc#newco...
tools/gn/target.cc:275: for (std::set<const Target*>::const_iterator cur =
for (const auto& cur : pair.ptr->recursive_hard_deps()) ?

[brettw, 2014-09-27 22:21:34]

https://codereview.chromium.org/610043002/diff/40001/tools/gn/target.cc
File tools/gn/target.cc (right):

https://codereview.chromium.org/610043002/diff/40001/tools/gn/target.cc#newco...
tools/gn/target.cc:275: for (std::set<const Target*>::const_iterator cur =
On 2014/09/27 00:40:07, scottmg wrote:
> for (const auto& cur : pair.ptr->recursive_hard_deps()) ?

I'm going to do another pass for the rest. I had to stop somewhere :)

[brettw, 2014-09-27 22:23:03]

https://codereview.chromium.org/610043002/diff/40001/tools/gn/command_refs.cc
File tools/gn/command_refs.cc (right):

https://codereview.chromium.org/610043002/diff/40001/tools/gn/command_refs.cc...
tools/gn/command_refs.cc:23: typedef std::vector<const Target*> TargetVector;
Thanks, will pick this up in the next pass if that's OK.

[brettw, 2014-09-27 22:23:09]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2014-09-27 22:23:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/610043002/40001

[commit-bot: I haz the power, 2014-09-27 22:27:20]

Committed patchset #3 (id:40001) as 54cbe3085cf3b0e9202e826e6f4629a1ee7dc46a

[commit-bot: I haz the power, 2014-09-27 22:28:04]

Patchset 3 (id:??) landed as
https://crrev.com/a09df11aa1c5f416df4fb97f2303d9c1ff76b150
Cr-Commit-Position: refs/heads/master@{#297122}