Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Unified Diff: tools/gn/ninja_group_target_writer.cc

Issue 610043002: Convert GN's deps iterator to work with range-based for loops. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/ninja_group_target_writer.cc
diff --git a/tools/gn/ninja_group_target_writer.cc b/tools/gn/ninja_group_target_writer.cc
index c672f269c59ba3420947097666e58e534e1581c7..c298413e0db6357266dafd54b2f1a6b935c15d9f 100644
--- a/tools/gn/ninja_group_target_writer.cc
+++ b/tools/gn/ninja_group_target_writer.cc
@@ -22,14 +22,13 @@ void NinjaGroupTargetWriter::Run() {
// A group rule just generates a stamp file with dependencies on each of
// the deps and data_deps in the group.
std::vector<OutputFile> output_files;
- for (DepsIterator iter(target_, DepsIterator::LINKED_ONLY);
- !iter.done(); iter.Advance())
- output_files.push_back(iter.target()->dependency_output_file());
+ for (const auto& pair : target_->GetDeps(Target::DEPS_LINKED))
+ output_files.push_back(pair.ptr->dependency_output_file());
std::vector<OutputFile> data_output_files;
const LabelTargetVector& data_deps = target_->data_deps();
- for (size_t i = 0; i < data_deps.size(); i++)
- data_output_files.push_back(data_deps[i].ptr->dependency_output_file());
+ for (const auto& pair : data_deps)
+ data_output_files.push_back(pair.ptr->dependency_output_file());
WriteStampForTarget(output_files, data_output_files);
}

Powered by Google App Engine
This is Rietveld 408576698