Convert GN's deps iterator to work with range-based for loops.

tools/gn/builder.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "tools/gn/builder.h"
 
 #include "tools/gn/config.h"
 #include "tools/gn/deps_iterator.h"
 #include "tools/gn/err.h"
 #include "tools/gn/loader.h"
@@ skipping 463 matching lines @@
 }
 
 // "Forward dependent configs" should refer to targets in the deps that should
 // have their configs forwarded.
 bool Builder::ResolveForwardDependentConfigs(Target* target, Err* err) {
   const UniqueVector<LabelTargetPair>& configs =
       target->forward_dependent_configs();
 
   // Assume that the lists are small so that brute-force n^2 is appropriate.
   for (size_t config_i = 0; config_i < configs.size(); config_i++) {
-    for (DepsIterator dep_iter(target, DepsIterator::LINKED_ONLY);
-         !dep_iter.done(); dep_iter.Advance()) {
-      if (configs[config_i].label == dep_iter.label()) {
-        DCHECK(dep_iter.target());  // Should already be resolved.
+    for (const auto& dep_pair : target->GetDeps(Target::DEPS_LINKED)) {
+      if (configs[config_i].label == dep_pair.label) {
+        DCHECK(dep_pair.ptr);  // Should already be resolved.
         // UniqueVector's contents are constant so uniqueness is preserved, but
         // we want to update this pointer which doesn't change uniqueness
         // (uniqueness in this vector is determined by the label only).
-        const_cast<LabelTargetPair&>(configs[config_i]).ptr = dep_iter.target();
+        const_cast<LabelTargetPair&>(configs[config_i]).ptr = dep_pair.ptr;
         break;
       }
     }
     if (!configs[config_i].ptr) {
       *err = Err(target->defined_from(),
           "Target in forward_dependent_configs_from was not listed in the deps",
           "This target has a forward_dependent_configs_from entry that was "
           "not present in\nthe deps. A target can only forward things it "
           "depends on. It was forwarding:\n  " +
           configs[config_i].label.GetUserVisibleName(false));
@@ skipping 30 matching lines @@
   std::string ret;
   for (size_t i = 0; i < cycle.size(); i++) {
     ret += "  " + cycle[i]->label().GetUserVisibleName(false);
     if (i != cycle.size() - 1)
       ret += " ->";
     ret += "\n";
   }
 
   return ret;
 }