Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: tools/skpdiff/SkCLImageDiffer.h

Issue 60833002: fix multithread related crashes in skpdiff (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: addressing comments Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/skpdiff/SkCLImageDiffer.h
diff --git a/tools/skpdiff/SkCLImageDiffer.h b/tools/skpdiff/SkCLImageDiffer.h
index 032ee6f9908bd00980109a36993cc0bc8c9ea300..6e9c2dc0cf64cb293c466c04fcf69ca6004a65b5 100644
--- a/tools/skpdiff/SkCLImageDiffer.h
+++ b/tools/skpdiff/SkCLImageDiffer.h
@@ -26,7 +26,7 @@ class SkCLImageDiffer : public SkImageDiffer {
public:
SkCLImageDiffer();
- virtual bool requiresOpenCL() SK_OVERRIDE { return true; }
+ virtual bool requiresOpenCL() const SK_OVERRIDE { return true; }
/**
* Initializes the OpenCL resources this differ needs to work
@@ -80,12 +80,15 @@ protected:
* @param image A pointer to return the allocated image to
* @return True on success, false otherwise
*/
- bool makeImage2D(SkBitmap* bitmap, cl_mem* image);
+ bool makeImage2D(SkBitmap* bitmap, cl_mem* image) const;
cl_device_id fDevice;
cl_context fContext;
cl_command_queue fCommandQueue;
+protected:
+ bool fIsGood;
+
private:
typedef SkImageDiffer INHERITED;

Powered by Google App Engine
This is Rietveld 408576698