Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: tools/skpdiff/SkImageDiffer.cpp

Issue 60833002: fix multithread related crashes in skpdiff (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: addressing comments Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/skpdiff/SkImageDiffer.h ('k') | tools/skpdiff/SkPMetric.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/skpdiff/SkImageDiffer.cpp
diff --git a/tools/skpdiff/SkImageDiffer.cpp b/tools/skpdiff/SkImageDiffer.cpp
index 40a34da6b13443f6dbebca48887bba1f9cec63ab..215a79989576e3ac5d2edcf2dd5e1e4aeb9c7d1a 100644
--- a/tools/skpdiff/SkImageDiffer.cpp
+++ b/tools/skpdiff/SkImageDiffer.cpp
@@ -14,25 +14,10 @@
const double SkImageDiffer::RESULT_CORRECT = 1.0f;
const double SkImageDiffer::RESULT_INCORRECT = 0.0f;
mtklein 2013/11/12 17:00:20 At this point you van probably just get rid of thi
-SkImageDiffer::SkImageDiffer()
- : fIsGood(true) {
+SkImageDiffer::SkImageDiffer() {
}
SkImageDiffer::~SkImageDiffer() {
}
-
-int SkImageDiffer::queueDiffOfFile(const char baseline[], const char test[]) {
- SkBitmap baselineBitmap;
- SkBitmap testBitmap;
- if (!SkImageDecoder::DecodeFile(baseline, &baselineBitmap)) {
- SkDebugf("Failed to load bitmap \"%s\"\n", baseline);
- return -1;
- }
- if (!SkImageDecoder::DecodeFile(test, &testBitmap)) {
- SkDebugf("Failed to load bitmap \"%s\"\n", test);
- return -1;
- }
- return this->queueDiff(&baselineBitmap, &testBitmap);
-}
« no previous file with comments | « tools/skpdiff/SkImageDiffer.h ('k') | tools/skpdiff/SkPMetric.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698